mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 06:25:54 +03:00
[GH-ISSUE #445] Server error with CSS files with new version #274
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#274
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pgrunm on GitHub (Jun 28, 2022).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/445
Hello, I'm running Shiori with my Raspberry pi behind a Caddy reverse proxy. I followed the guide here to run Shiori behind Caddy as reverse proxy.
Until the last update everything was fine, but since 1.5.3 any CSS file isn't loaded correctly if you run Shiori like this shiori serve --webroot /shiori/ parameter. In Firefox I can see internal server errors (HTTP code 500) and this is also displayed on the console but no further information.
The page as result looks like this now:
And now the great part: If you run Shiori without the --webroot /shiori/ parameter, everything is fine. I also verified this on my local machine, once with the parameter and once without, same result as with the Raspberry Pi, without reverse proxy of course.
Steps to reproduce
source-sans-pro.min.cssfile as an example my browser says the following:open /css/source-sans-pro.min.css: invalid name. The corresponding log entry from the containers log is:time="2022-06-28T17:43:40Z" level=warning msg="GET /shiori/css/source-sans-pro.min.css" proto=HTTP/1.1 remote="172.19.0.2:43460" reqlen=0 size=48 status=500@hulb commented on GitHub (Jul 6, 2022):
Sorry for your trouble, it will be fixed when the PR merged
@pgrunm commented on GitHub (Jul 7, 2022):
No problem, I appreciate your upcoming fix. :-)
@fmartingr commented on GitHub (Jul 8, 2022):
Hey @pgrunm, I just merged @hulb's fix. Please check if this solves it, if not, please reopen the issue so we can take a look.
@pgrunm commented on GitHub (Jul 8, 2022):
Works great, thank you very much! 👍