mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 06:25:54 +03:00
[GH-ISSUE #430] [Bug] Shiori won't stay signed in, even when ticking the option #266
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#266
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @t3dium on GitHub (May 29, 2022).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/430
I thought this issue was fixed in my previous issue: 416, but that only saved the session for 24 hours (and not the intended 30 days), after which it expires again.
Client OS: arch, w10, ipados
Server: Docker, default config latest, ubuntu server
@fmartingr commented on GitHub (Jun 23, 2022):
Hey @t3dium, which browser are you using? I'm working on a little fix of duplicated code regarding sessions (expire time will be sent by te server until I implement a proper session with JWTs refresh tokens) and in my tests the session is set to one hour without the checkbox enabled and to 30 days with it, but in Safari (macOS) the expire time is set to 7 days due to a "feature" implemented in the browser. Maybe your browser has something similar? Qutebrowser correctly sets cookie duration as expected.
@t3dium commented on GitHub (Jun 24, 2022):
@fmartingr I'm using firefox on desktop, but I've also reproduced the issue on safari (ipados)
strangely however I've noticed the shiori web extension always stays signed in on windows, and the addon doesn't encounter this issue, but not on linux using the same browser