[GH-ISSUE #409] Link breaks after saving #256

Closed
opened 2026-02-25 23:33:48 +03:00 by kerem · 2 comments
Owner

Originally created by @GamerBS on GitHub (Mar 25, 2022).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/409

When I try to save the link in the following example the link doesn't work anymore because an equal sign is added to the end. When I try to delete the equal sign it just gets added automatically again.
Example:
Trying to save:
https://comicforum.de/showthread.php?157893-Zensur-in-deutschen-Mangaver%C3%B6ffentlichungen

Actually being saved:
https://comicforum.de/showthread.php?157893-Zensur-in-deutschen-Mangaver%C3%B6ffentlichungen=

Shiori Version: 1.5.2

Originally created by @GamerBS on GitHub (Mar 25, 2022). Original GitHub issue: https://github.com/go-shiori/shiori/issues/409 When I try to save the link in the following example the link doesn't work anymore because an equal sign is added to the end. When I try to delete the equal sign it just gets added automatically again. Example: Trying to save: https://comicforum.de/showthread.php?157893-Zensur-in-deutschen-Mangaver%C3%B6ffentlichungen Actually being saved: https://comicforum.de/showthread.php?157893-Zensur-in-deutschen-Mangaver%C3%B6ffentlichungen= Shiori Version: 1.5.2
Author
Owner

@fmartingr commented on GitHub (Mar 26, 2022):

Hey @GamerBS I've successfully reproduced this issue and a fix is underway. Thanks for reporting it!

Keep in mind that this is just a workaround because server side should behave the same even which the trailing equal sign, but well...

This was happening when rebuilding the URL after removing utm_ social associated parameters here

Relates to: https://github.com/golang/go/issues/20820

<!-- gh-comment-id:1079630967 --> @fmartingr commented on GitHub (Mar 26, 2022): Hey @GamerBS I've successfully reproduced this issue and a fix is underway. Thanks for reporting it! Keep in mind that this is just a workaround because server side should behave the same even which the trailing equal sign, but well... This was happening when rebuilding the URL after removing `utm_` social associated parameters [here](https://github.com/go-shiori/shiori/blob/master/internal/core/url.go) Relates to: https://github.com/golang/go/issues/20820
Author
Owner

@GamerBS commented on GitHub (Mar 26, 2022):

Thank you for your fast help.

<!-- gh-comment-id:1079672194 --> @GamerBS commented on GitHub (Mar 26, 2022): Thank you for your fast help.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#256
No description provided.