mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #32] Delete fails from web interface #21
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#21
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @csterritt on GitHub (Mar 2, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/32
I created several test links with the web front end, and tried deleting one. I got an error message, "no token present in request".
@RadhiFadlillah commented on GitHub (Mar 5, 2018):
Hi @csterritt, sorry for late response.
So, while using the web interface, you succeed on adding several new bookmarks, but failed when deleting one of them ?
That message means that user session already ended, which makes the token expired and you have to login again. Do you delete the bookmark right after adding it, or several hours after adding it ?
Thanks.
@csterritt commented on GitHub (Mar 5, 2018):
Hi @RadhiFadlillah -- it was pretty much immediate, within a minute.
@RadhiFadlillah commented on GitHub (Jun 7, 2018):
@csterritt sorry for late response.
After checking around, I don't think this issue is a bug. The error message
no token presentmeans the user session already ended, so user have to login again, and this is the intended behaviour.For now I've added better error message for clarity, and redirected user to login page when token expired (commit
4deed23).