[GH-ISSUE #279] Failed to build from source using go get command, warc processor throw error #202

Closed
opened 2026-02-25 23:33:41 +03:00 by kerem · 3 comments
Owner

Originally created by @venssy on GitHub (Oct 17, 2020).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/279

I try to build by running go get -u -v github.com/go-shiori/shiori, then i can't find executable in $GOPATH/bin, and i notice two problem or warning, what should i do?
# github.com/go-shiori/warc/internal/processor
go/src/github.com/go-shiori/warc/internal/processor/css.go:39:23: cannot use input (type io.Reader) as type *parse.Input in argument to css.NewLexer
go/src/github.com/go-shiori/warc/internal/processor/js.go:27:22: cannot use input (type io.Reader) as type *parse.Input in argument to js.NewLexer

I run on debian9, try with go1.12, 1.13 and 1.15, all same output.

Originally created by @venssy on GitHub (Oct 17, 2020). Original GitHub issue: https://github.com/go-shiori/shiori/issues/279 I try to build by running `go get -u -v github.com/go-shiori/shiori`, then i can't find executable in $GOPATH/bin, and i notice two problem or warning, what should i do? _# github.com/go-shiori/warc/internal/processor go/src/github.com/go-shiori/warc/internal/processor/css.go:39:23: cannot use input (type io.Reader) as type *parse.Input in argument to css.NewLexer go/src/github.com/go-shiori/warc/internal/processor/js.go:27:22: cannot use input (type io.Reader) as type *parse.Input in argument to js.NewLexer_ I run on debian9, try with go1.12, 1.13 and 1.15, all same output.
kerem closed this issue 2026-02-25 23:33:41 +03:00
Author
Owner

@mailinglists35 commented on GitHub (Oct 23, 2020):

same here. ubuntu 18.04 lts, golang 1.15

<!-- gh-comment-id:715637153 --> @mailinglists35 commented on GitHub (Oct 23, 2020): same here. ubuntu 18.04 lts, golang 1.15
Author
Owner

@jcm4atx commented on GitHub (Jul 11, 2021):

I found a fix, but now have another problem. Although looks like a completely unrelated problem.

In the file go/pkg/mod/github.com/go-shiori/shiori@v1.5.0/pkg/warc/internal/archiver/processor.go I changed these lines near the top:

"github.com/tdewolff/parse/v2/css"
"github.com/tdewolff/parse/v2/js"

to this

"github.com/tdewolff/parse/css"
"github.com/tdewolff/parse/js"

But now I have an error further into the build.

go/pkg/mod/github.com/go-shiori/shiori@v1.5.0/internal/core/processing.go:68:17: undefined: readability.IsReadable
go/pkg/mod/github.com/go-shiori/shiori@v1.5.0/internal/core/processing.go:70:64: cannot use book.URL (type string) as type *url.URL in argument to readability.FromReader

I don't know golang whatsoever and I'm not certain what I changed even makes sense.

<!-- gh-comment-id:877851482 --> @jcm4atx commented on GitHub (Jul 11, 2021): I found a fix, but now have another problem. Although looks like a completely unrelated problem. In the file `go/pkg/mod/github.com/go-shiori/shiori@v1.5.0/pkg/warc/internal/archiver/processor.go` I changed these lines near the top: ``` "github.com/tdewolff/parse/v2/css" "github.com/tdewolff/parse/v2/js" ``` to this ``` "github.com/tdewolff/parse/css" "github.com/tdewolff/parse/js" ``` But now I have an error further into the build. ``` go/pkg/mod/github.com/go-shiori/shiori@v1.5.0/internal/core/processing.go:68:17: undefined: readability.IsReadable go/pkg/mod/github.com/go-shiori/shiori@v1.5.0/internal/core/processing.go:70:64: cannot use book.URL (type string) as type *url.URL in argument to readability.FromReader ``` I don't know golang whatsoever and I'm not certain what I changed even makes sense.
Author
Owner

@fmartingr commented on GitHub (Feb 10, 2022):

It seems that one shiori dependency to package archives is unmaintained. We need to replace it.

Moved to #353

<!-- gh-comment-id:1035457438 --> @fmartingr commented on GitHub (Feb 10, 2022): It seems that one shiori dependency to package archives is unmaintained. We need to replace it. Moved to #353
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#202
No description provided.