starred/shiori

Fork 0

mirror of https://github.com/go-shiori/shiori.git synced 2026-04-25 06:25:54 +03:00

[GH-ISSUE #6] Missing assets folder #2

New issue

Closed

opened 2026-02-25 23:33:13 +03:00 by kerem · 5 comments

kerem commented

2026-02-25 23:33:13 +03:00

Owner

Originally created by @x2764tech on GitHub (Mar 1, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/6

I can't build this as there's a missing assets package, referenced from serve.go

Originally created by @x2764tech on GitHub (Mar 1, 2018). Original GitHub issue: https://github.com/go-shiori/shiori/issues/6 I can't build this as there's a missing `assets` package, referenced from [serve.go](https://github.com/RadhiFadlillah/shiori/blob/master/cmd/serve.go#L8)

kerem closed this issue

2026-02-25 23:33:13 +03:00

kerem commented

2026-02-25 23:33:14 +03:00

Author

Owner

@Zhann commented on GitHub (Mar 1, 2018):

have this very same issue

Was this folder renamed to view? There's not go files in there though.

@Zhann commented on GitHub (Mar 1, 2018): have this very same issue ---- Was this folder renamed to view? There's not go files in there though.

kerem commented

2026-02-25 23:33:14 +03:00

Author

Owner

@cron410 commented on GitHub (Mar 1, 2018):

its in .gitignore, which keeps it from being pushed from the author's local Git repo into this one.

@cron410 commented on GitHub (Mar 1, 2018): its in .gitignore, which keeps it from being pushed from the author's local Git repo into this one.

kerem commented

2026-02-25 23:33:14 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 1, 2018):

Man, it's embarassing. Sorry for inconvenience.

Yeah, the assets folder is supposed to be generated by go generate, thats why I list it in gitignore. I forgot that go generate doesn't run automatically by go get.

It should be fixed by 3b8ce6c.

@RadhiFadlillah commented on GitHub (Mar 1, 2018): Man, it's embarassing. Sorry for inconvenience. Yeah, the `assets` folder is supposed to be generated by `go generate`, thats why I list it in `gitignore`. I forgot that `go generate` [doesn't run automatically](https://golang.org/cmd/go/#hdr-Generate_Go_files_by_processing_source) by `go get`. It should be fixed by [3b8ce6c](https://github.com/RadhiFadlillah/shiori/commit/3b8ce6ce0d77fb744e9ad2bc21193269cace7a6c).

kerem commented

2026-02-25 23:33:14 +03:00

Author

Owner

@skx commented on GitHub (Mar 2, 2018):

I can confirm that this now works, so this issue can be closed :)

@skx commented on GitHub (Mar 2, 2018): I can confirm that this now works, so this issue can be closed :)

kerem commented

2026-02-25 23:33:14 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 2, 2018):

I can confirm that this now works, so this issue can be closed :)

Thanks for the confirmation.

@RadhiFadlillah commented on GitHub (Mar 2, 2018): > I can confirm that this now works, so this issue can be closed :) Thanks for the confirmation.

kerem referenced this issue

2026-02-25 23:33:24 +03:00

[GH-ISSUE #112] Feature request: add a flag to mark each bookmark public or private #80

kerem referenced this issue

2026-02-25 23:33:53 +03:00

[GH-ISSUE #475] Error with docker image #291

kerem referenced this issue

2026-02-25 23:34:29 +03:00

[PR #2] [MERGED] add systemd file #488