mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #263] docker doesn't compile correctly or build when pulling from master #192
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#192
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @symgryph on GitHub (Aug 9, 2020).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/263
I tried using the dockerfile, system crashes with the following:
github.com/lib/pq/scram
github.com/go-shiori/shiori/internal/core
github.com/lib/pq
github.com/mattn/go-sqlite3
github.com/shurcooL/httpfs/vfsutil
github.com/shurcooL/vfsgen
github.com/go-shiori/shiori/internal/webserver
github.com/spf13/cobra
github.com/go-shiori/shiori/internal/cmd
github.com/go-shiori/shiori/internal/cmd
src/github.com/go-shiori/shiori/internal/cmd/root.go:93:32: too many arguments in call to gap.NewScope
have (gap.ScopeType, string, string)
want (gap.ScopeType, string)
src/github.com/go-shiori/shiori/internal/cmd/root.go:94:27: userScope.DataDir undefined (type *gap.Scope has no field or method DataDir)
@lapwat commented on GitHub (Aug 11, 2020):
This is because of this line:
github.com/go-shiori/shiori@b7a5a61e01/internal/cmd/root.go (L93)The
apppathsvariable is of typeScope. This type was imported fromhttps://github.com/muesli/go-app-pathsThe
NewScopesignature has "recently" changed:github.com/muesli/go-app-paths@549218f8b8 (diff-d44c7badbd)@lapwat commented on GitHub (Aug 11, 2020):
Also, DataDir got replaced by DataDirs returning a prioritized list of data directories
See changelog here: https://github.com/muesli/go-app-paths/releases/tag/v0.2.0
@lapwat commented on GitHub (Aug 11, 2020):
Please accept the pull request: https://github.com/go-shiori/shiori/pull/264
@fmartingr commented on GitHub (Feb 6, 2022):
This is currently working (thanks for your PR) and we're planning changes in #278 and #341 as well. We will need a dependency update after that.