[GH-ISSUE #263] docker doesn't compile correctly or build when pulling from master #192

Closed
opened 2026-02-25 23:33:40 +03:00 by kerem · 4 comments
Owner

Originally created by @symgryph on GitHub (Aug 9, 2020).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/263

I tried using the dockerfile, system crashes with the following:

github.com/lib/pq/scram
github.com/go-shiori/shiori/internal/core
github.com/lib/pq
github.com/mattn/go-sqlite3
github.com/shurcooL/httpfs/vfsutil
github.com/shurcooL/vfsgen
github.com/go-shiori/shiori/internal/webserver
github.com/spf13/cobra
github.com/go-shiori/shiori/internal/cmd

github.com/go-shiori/shiori/internal/cmd

src/github.com/go-shiori/shiori/internal/cmd/root.go:93:32: too many arguments in call to gap.NewScope
have (gap.ScopeType, string, string)
want (gap.ScopeType, string)
src/github.com/go-shiori/shiori/internal/cmd/root.go:94:27: userScope.DataDir undefined (type *gap.Scope has no field or method DataDir)

Originally created by @symgryph on GitHub (Aug 9, 2020). Original GitHub issue: https://github.com/go-shiori/shiori/issues/263 I tried using the dockerfile, system crashes with the following: github.com/lib/pq/scram github.com/go-shiori/shiori/internal/core github.com/lib/pq github.com/mattn/go-sqlite3 github.com/shurcooL/httpfs/vfsutil github.com/shurcooL/vfsgen github.com/go-shiori/shiori/internal/webserver github.com/spf13/cobra github.com/go-shiori/shiori/internal/cmd # github.com/go-shiori/shiori/internal/cmd src/github.com/go-shiori/shiori/internal/cmd/root.go:93:32: too many arguments in call to gap.NewScope have (gap.ScopeType, string, string) want (gap.ScopeType, string) src/github.com/go-shiori/shiori/internal/cmd/root.go:94:27: userScope.DataDir undefined (type *gap.Scope has no field or method DataDir)
kerem 2026-02-25 23:33:40 +03:00
Author
Owner

@lapwat commented on GitHub (Aug 11, 2020):

This is because of this line:

github.com/go-shiori/shiori@b7a5a61e01/internal/cmd/root.go (L93)

The apppaths variable is of type Scope. This type was imported from https://github.com/muesli/go-app-paths

The NewScope signature has "recently" changed:

github.com/muesli/go-app-paths@549218f8b8 (diff-d44c7badbd)

<!-- gh-comment-id:672288138 --> @lapwat commented on GitHub (Aug 11, 2020): This is because of this line: https://github.com/go-shiori/shiori/blob/b7a5a61e011e5613984043d55125aa4b33c7e7ea/internal/cmd/root.go#L93 The `apppaths` variable is of type `Scope`. This type was imported from `https://github.com/muesli/go-app-paths` The `NewScope` signature has "recently" changed: https://github.com/muesli/go-app-paths/commit/549218f8b8d039b96fae900db39f1c1e737d45da#diff-d44c7badbd1491a3c4c5bbaf9f55d173R39
Author
Owner

@lapwat commented on GitHub (Aug 11, 2020):

Also, DataDir got replaced by DataDirs returning a prioritized list of data directories

See changelog here: https://github.com/muesli/go-app-paths/releases/tag/v0.2.0

<!-- gh-comment-id:672290717 --> @lapwat commented on GitHub (Aug 11, 2020): Also, DataDir got replaced by DataDirs returning a prioritized list of data directories See changelog here: https://github.com/muesli/go-app-paths/releases/tag/v0.2.0
Author
Owner

@lapwat commented on GitHub (Aug 11, 2020):

Please accept the pull request: https://github.com/go-shiori/shiori/pull/264

<!-- gh-comment-id:672336972 --> @lapwat commented on GitHub (Aug 11, 2020): Please accept the pull request: https://github.com/go-shiori/shiori/pull/264
Author
Owner

@fmartingr commented on GitHub (Feb 6, 2022):

This is currently working (thanks for your PR) and we're planning changes in #278 and #341 as well. We will need a dependency update after that.

<!-- gh-comment-id:1030868154 --> @fmartingr commented on GitHub (Feb 6, 2022): This is currently working (thanks for your PR) and we're planning changes in #278 and #341 as well. We will need a dependency update after that.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#192
No description provided.