[GH-ISSUE #251] Allow users to select between light, dark and follow system themes #186

Closed
opened 2026-02-25 23:33:39 +03:00 by kerem · 4 comments
Owner

Originally created by @IronPiston on GitHub (May 24, 2020).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/251

Originally assigned to: @Monirzadeh on GitHub.

Right now theme selection is inconsistent, since we can just check to use dark theme or not, but when the checkbox is not checked the browser may follow the system theme.

The idea here is to update this setting to allow selecting three options:

  • Light theme
  • Dark theme
  • Follow system

Options should be self-explanatory


Original comment

Upon installation, the webpage has the dark theme by default. Under settings, the dark theme toggle is unchecked. Toggling it and refreshing the webpage doesn't seem to enable the light theme.

Originally created by @IronPiston on GitHub (May 24, 2020). Original GitHub issue: https://github.com/go-shiori/shiori/issues/251 Originally assigned to: @Monirzadeh on GitHub. Right now theme selection is inconsistent, since we can just check to use dark theme or not, but when the checkbox is not checked the browser may follow the system theme. The idea here is to update this setting to allow selecting three options: - Light theme - Dark theme - Follow system Options should be self-explanatory --- ## Original comment Upon installation, the webpage has the dark theme by default. Under settings, the dark theme toggle is unchecked. Toggling it and refreshing the webpage doesn't seem to enable the light theme.
Author
Owner

@evanrichter commented on GitHub (Jun 3, 2020):

Are you on firefox by chance? this is the behavior for me as well. It might be the browser sending it's general dark theme preferences

<!-- gh-comment-id:637883056 --> @evanrichter commented on GitHub (Jun 3, 2020): Are you on firefox by chance? this is the behavior for me as well. It might be the browser sending it's general dark theme preferences
Author
Owner

@IronPiston commented on GitHub (Jun 19, 2020):

Both Firefox and my Chromium based browser on Android 10 only display the dark mode regardless of system-wide or browser dark theme toggles.

<!-- gh-comment-id:646425459 --> @IronPiston commented on GitHub (Jun 19, 2020): Both Firefox and my Chromium based browser on Android 10 only display the dark mode regardless of system-wide or browser dark theme toggles.
Author
Owner

@deanishe commented on GitHub (Aug 6, 2020):

The "Use dark theme" setting only forces dark mode, AFAIK. If unchecked, Shiori will do what the browser tells it to.

I don't have an Android device to test this. How do other sites that support dark mode behave in the affected browsers?

<!-- gh-comment-id:670207086 --> @deanishe commented on GitHub (Aug 6, 2020): The "Use dark theme" setting only *forces* dark mode, AFAIK. If unchecked, Shiori will do what the browser tells it to. I don't have an Android device to test this. How do other sites that support dark mode behave in the affected browsers?
Author
Owner

@ragekit commented on GitHub (May 3, 2024):

A quick fix would be to remove all prefers-color-scheme from the CSS, and use the toggle just as a Dark/Light theme
If you want to keep the possibility to follow the computer preffered scheme, you could add a dropwodn, dark/light/system and change the css accordingly.

<!-- gh-comment-id:2091957191 --> @ragekit commented on GitHub (May 3, 2024): A quick fix would be to remove all prefers-color-scheme from the CSS, and use the toggle just as a Dark/Light theme If you want to keep the possibility to follow the computer preffered scheme, you could add a dropwodn, dark/light/system and change the css accordingly.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#186
No description provided.