mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #251] Allow users to select between light, dark and follow system themes #186
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#186
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @IronPiston on GitHub (May 24, 2020).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/251
Originally assigned to: @Monirzadeh on GitHub.
Right now theme selection is inconsistent, since we can just check to use dark theme or not, but when the checkbox is not checked the browser may follow the system theme.
The idea here is to update this setting to allow selecting three options:
Options should be self-explanatory
Original comment
Upon installation, the webpage has the dark theme by default. Under settings, the dark theme toggle is unchecked. Toggling it and refreshing the webpage doesn't seem to enable the light theme.
@evanrichter commented on GitHub (Jun 3, 2020):
Are you on firefox by chance? this is the behavior for me as well. It might be the browser sending it's general dark theme preferences
@IronPiston commented on GitHub (Jun 19, 2020):
Both Firefox and my Chromium based browser on Android 10 only display the dark mode regardless of system-wide or browser dark theme toggles.
@deanishe commented on GitHub (Aug 6, 2020):
The "Use dark theme" setting only forces dark mode, AFAIK. If unchecked, Shiori will do what the browser tells it to.
I don't have an Android device to test this. How do other sites that support dark mode behave in the affected browsers?
@ragekit commented on GitHub (May 3, 2024):
A quick fix would be to remove all prefers-color-scheme from the CSS, and use the toggle just as a Dark/Light theme
If you want to keep the possibility to follow the computer preffered scheme, you could add a dropwodn, dark/light/system and change the css accordingly.