mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #189] Option for passing bookmark URL in as query parameter #141
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#141
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @timshannon on GitHub (Oct 2, 2019).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/189
Since bookmarklet support has been dropped favor of the extension (#180), it be nice to have a fall back for any other scenario where the extension doesn't work (other browsers, locked down browser environments, etc).
Simply accepting a URL parm at the root page that automatically opens the Add bookmark dialog and pre-populates the URL from the parameter value would allow for this.
https://my-shiori-url.com?add_url=https%3A%2F%2Fgoogle.comI may add a PR for this, if you think it's a reasonable addition. It should be able to be done entirely in the frontend Vue code.
@deanishe commented on GitHub (Aug 7, 2020):
Bookmarklet support is important to me. It's simpler, and much more widely supported, than browser extensions.
@clach04 commented on GitHub (Aug 16, 2020):
I don't have a strong opinion on what the URL should be but #84 with commit
4b939379e8introduced/submit?url=- see:github.com/go-shiori/shiori@4b939379e8 (diff-52f15f47c4)github.com/go-shiori/shiori@4b939379e8 (diff-68382b9aa5)github.com/go-shiori/shiori@4b939379e8 (diff-b15905fa00)This was a fallback for non-https installations (I'm personally running a private instance withOUT https).
I'd recommend adopting the previous URL (and bookmarklet) support.
@deanishe commented on GitHub (Aug 20, 2020):
Was that removed? That's definitely going back in. Looks like it worked perfectly.
A GET-based submission endpoint is essential, imo. It allows you to integrate Shiori with almost anything.