mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #24] Feature Request: Generate image if none available #13
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#13
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @heliostatic on GitHub (Mar 2, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/24
When adding or updating a bookmark, Shiori currently grabs the image url from the meta tags of the site (https://github.com/RadhiFadlillah/shiori/blob/master/cmd/add.go#L71).
However, if a site doesn't have an image, none is assigned.
Ideally, if no image is available, Shiori could generate one using PhantomJS or Chrome Headless. One Golang project to do so is Gowitness (go + chrome headless).
@RadhiFadlillah commented on GitHub (Mar 6, 2018):
Hi @heliostatic
I've been considering adding that feature before. However, I dropped it because it requires additional dependencies like Chrome, which I think overkill just to fetch the screenshot.
I will consider to use favicon as alternative if featured image doesn't exist. It's far easier and doesn't requires any dependencies. Besides favicon nowadays is quite large thanks to Apple spec.
I will move this issue to RadhiFadlillah/go-readability#5.