starred/shiori

Fork 0

mirror of https://github.com/go-shiori/shiori.git synced 2026-04-25 14:35:52 +03:00

[GH-ISSUE #148] ability to edit the old url's? #111

New issue

Closed

opened 2026-02-25 23:33:28 +03:00 by kerem · 12 comments

kerem commented

2026-02-25 23:33:28 +03:00

Owner

Originally created by @thepenguinthatwants on GitHub (Sep 2, 2019).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/148

I sometimes update certain url's but seems like Shiori is unable to edit a URL once entered.

Originally created by @thepenguinthatwants on GitHub (Sep 2, 2019). Original GitHub issue: https://github.com/go-shiori/shiori/issues/148 I sometimes update certain url's but seems like Shiori is unable to edit a URL once entered.

kerem closed this issue

2026-02-25 23:33:28 +03:00

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Sep 5, 2019):

Hi @thepenguinthatwants, edit URL is supported in latest version of Shiori.

From cli you can use --url flag in update command like this :

shiori update --url http://example.com 123

In web interface you can modify the URL in edit dialog :

@RadhiFadlillah commented on GitHub (Sep 5, 2019): Hi @thepenguinthatwants, edit URL is supported in latest version of Shiori. From cli you can use `--url` flag in `update` command like this : ``` shiori update --url http://example.com 123 ``` In web interface you can modify the URL in edit dialog : ![Screenshot_2019-09-05 Shiori - Bookmarks Manager](https://user-images.githubusercontent.com/6129042/64318348-0b43da00-cfe4-11e9-8fed-62eefd1274c3.png)

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@thepenguinthatwants commented on GitHub (Sep 5, 2019):

Hi!

Oh cool.

I am using the docker image and it hadn't have this feature yet.

@thepenguinthatwants commented on GitHub (Sep 5, 2019): Hi! Oh cool. I am using the docker image and it hadn't have this feature yet.

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Sep 5, 2019):

@thepenguinthatwants yeah, I haven't updated the docker image in a while.

I will try to update docker image ASAP.

@RadhiFadlillah commented on GitHub (Sep 5, 2019): @thepenguinthatwants yeah, I haven't updated the docker image in a while. I will try to update docker image ASAP.

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@thepenguinthatwants commented on GitHub (Sep 5, 2019):

Thanks!

There are quite many that uses the docker image. Really thankful that about this application.

@thepenguinthatwants commented on GitHub (Sep 5, 2019): Thanks! There are quite many that uses the docker image. Really thankful that about this application.

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Sep 21, 2019):

Hi @thepenguinthatwants, the Docker image has been updated and can be pulled by running :

docker pull radhifadlillah/shiori

@RadhiFadlillah commented on GitHub (Sep 21, 2019): Hi @thepenguinthatwants, the Docker image has been updated and can be pulled by running : ``` docker pull radhifadlillah/shiori ```

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@thepenguinthatwants commented on GitHub (Sep 22, 2019):

Hi!
Thanks it looks good. But how to edit entries? I cant see any options or clickable things for editing the information? Feels like all I can do is about opening the url.

@thepenguinthatwants commented on GitHub (Sep 22, 2019): Hi! Thanks it looks good. But how to edit entries? I cant see any options or clickable things for editing the information? Feels like all I can do is about opening the url.

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@thepenguinthatwants commented on GitHub (Sep 22, 2019):

Actually after the update it seems like my user has lost all the rights?

@thepenguinthatwants commented on GitHub (Sep 22, 2019): Actually after the update it seems like my user has lost all the rights?

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@hoijui commented on GitHub (Sep 22, 2019):

same here.
(I am using latest git version, can easily test new stuff if you have something to test)

@hoijui commented on GitHub (Sep 22, 2019): same here. (I am using latest git version, can easily test new stuff if you have something to test)

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Sep 22, 2019):

@thepenguinthatwants @hoijui I'm so sorry for the trouble 😞

This issue happened because in Shiori v1.0.0 there are no account level, which means everyone is treated as owner. However, Shiori v1.5.0 has two account level i.e. owner and visitor. The level difference is stored in database as boolean value in column owner with default value false (which means by default all account is visitor, unless specified otherwise)

github.com/go-shiori/shiori@89aad30a17/internal/database/sqlite.go (L41-L48)

Because in v1.5.0 by default all account is visitor, when updating from v1.0 to v1.5 all of the old accounts by default will be marked as visitor. Fortunately, when there are no owner registered in database, we can login as owner using default account :

username: shiori
password: gopher

So, as workaround for this issue, you should :

Login as default account.
Go to options page.
Remove your old accounts.
Recreate them, but now as owner.

@RadhiFadlillah commented on GitHub (Sep 22, 2019): @thepenguinthatwants @hoijui I'm so sorry for the trouble :disappointed: This issue happened because in Shiori v1.0.0 there are no account level, which means everyone is treated as owner. However, Shiori v1.5.0 has two account level i.e. owner and visitor. The level difference is stored in database as boolean value in column `owner` with default value `false` (which means by default all account is visitor, unless specified otherwise) https://github.com/go-shiori/shiori/blob/89aad30a177a512ef3984699202c26d8c5cd1f89/internal/database/sqlite.go#L41-L48 Because in v1.5.0 by default all account is visitor, when updating from v1.0 to v1.5 all of the old accounts by default will be marked as visitor. Fortunately, when there are no `owner` registered in database, we can login as owner using default account : ``` username: shiori password: gopher ``` So, as workaround for this issue, you should : - Login as default account. - Go to options page. - Remove your old accounts. - Recreate them, but now as owner. ![bug-2019-09-22_15 39 13](https://user-images.githubusercontent.com/6129042/65384738-fab79180-dd4f-11e9-9838-72ca840b6e97.gif)

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@thepenguinthatwants commented on GitHub (Sep 22, 2019):

So existing users cant be changed into admins?

Also is it possible to delete the shiori account?

@thepenguinthatwants commented on GitHub (Sep 22, 2019): So existing users cant be changed into admins? Also is it possible to delete the shiori account?

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Sep 22, 2019):

So existing users cant be changed into admins?

Yeah, for now I haven't add the menu to change account level, so the workaround is delete it then create a new one with same name.

Also is it possible to delete the shiori account?

The shiori account will be disabled once there is at least one owner account registered in database, as can be seen in these lines.

@RadhiFadlillah commented on GitHub (Sep 22, 2019): > So existing users cant be changed into admins? Yeah, for now I haven't add the menu to change account level, so the workaround is delete it then create a new one with same name. > Also is it possible to delete the shiori account? The `shiori` account will be disabled once there is at least one owner account registered in database, as can be seen in these [lines](https://github.com/go-shiori/shiori/blob/fbd4e376435831316aee7fa890e58e7e9d1816f6/internal/webserver/handler-api.go#L76-L91).

kerem commented

2026-02-25 23:33:28 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Oct 4, 2019):

Since it seems this issue has been solved, I will close it. Feel free to reopen it if needed.

@RadhiFadlillah commented on GitHub (Oct 4, 2019): Since it seems this issue has been solved, I will close it. Feel free to reopen it if needed.