starred/shannon-KeygraphHQ
1
0
Fork 0
mirror of https://github.com/KeygraphHQ/shannon.git synced 2026-04-25 01:25:52 +03:00
Code Issues 18 Projects Releases Packages Wiki Activity

[PR #68] fix: improve error messaging for agent output validation failures #101

New issue
Open
opened 2026-02-27 07:20:26 +03:00 by kerem · 0 comments
kerem commented 2026-02-27 07:20:26 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/KeygraphHQ/shannon/pull/68
Author: @Mr-Neutr0n
Created: 2/6/2026
Status: 🔄 Open

Base: main ← Head: fix/prerecon-error-messaging

📝 Commits (1)

  • b1a42ec fix: improve error messaging for agent output validation failures

📊 Changes

2 files changed (+20 additions, -1 deletions)

View changed files

📝 src/ai/claude-executor.ts (+9 -0)
📝 src/temporal/activities.ts (+11 -1)

📄 Description

Summary

Improve error messages when agents fail to create required deliverable files, making it easier to diagnose and fix common issues.

Problem

When the pre-recon agent (or other agents) fail to create required deliverable files, users see a generic error:

Agent pre-recon failed output validation after 3 attempts

This doesn't help users understand what went wrong or how to fix it.

Solution

Add troubleshooting tips and more detailed logging:

  1. Troubleshooting tips in error message (for pre-recon agent):

    • Check if repository path is accessible
    • If using ROUTER mode, ensure model supports tool use
    • Check agent logs location
    • Try Claude models (recommended)
    • Ensure target URL is reachable from Docker

  2. Log expected file path when validation fails:

    Expected file: /path/to/repo/deliverables/code_analysis_deliverable.md

Common causes this helps diagnose

  • Using router mode with models that don't follow instructions well
  • Repository path not accessible from Docker container
  • Target URL not reachable (should use host.docker.internal for local apps)

Test plan

  • Run Shannon with an intentionally inaccessible repo path
  • Verify improved error message appears with troubleshooting tips
  • Verify expected file path is logged on validation failure

Fixes #62

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/KeygraphHQ/shannon/pull/68 **Author:** [@Mr-Neutr0n](https://github.com/Mr-Neutr0n) **Created:** 2/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/prerecon-error-messaging` --- ### 📝 Commits (1) - [`b1a42ec`](https://github.com/KeygraphHQ/shannon/commit/b1a42ec4e03309cc5482dc0317c3c0b04a90b21a) fix: improve error messaging for agent output validation failures ### 📊 Changes **2 files changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/ai/claude-executor.ts` (+9 -0) 📝 `src/temporal/activities.ts` (+11 -1) </details> ### 📄 Description ## Summary Improve error messages when agents fail to create required deliverable files, making it easier to diagnose and fix common issues. ## Problem When the pre-recon agent (or other agents) fail to create required deliverable files, users see a generic error: ``` Agent pre-recon failed output validation after 3 attempts ``` This doesn't help users understand what went wrong or how to fix it. ## Solution Add troubleshooting tips and more detailed logging: 1. **Troubleshooting tips in error message** (for pre-recon agent): - Check if repository path is accessible - If using ROUTER mode, ensure model supports tool use - Check agent logs location - Try Claude models (recommended) - Ensure target URL is reachable from Docker 2. **Log expected file path** when validation fails: ``` Expected file: /path/to/repo/deliverables/code_analysis_deliverable.md ``` ## Common causes this helps diagnose - Using router mode with models that don't follow instructions well - Repository path not accessible from Docker container - Target URL not reachable (should use `host.docker.internal` for local apps) ## Test plan - [ ] Run Shannon with an intentionally inaccessible repo path - [ ] Verify improved error message appears with troubleshooting tips - [ ] Verify expected file path is logged on validation failure Fixes #62 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/npx-integration
Readme-Update
feat/telemetry
ctf-mode
v1.1.0
v1.0.0
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shannon-KeygraphHQ#101
No description provided.