[GH-ISSUE #2568] [APP BUG]: Deleting a game causes information to be copied incorrectly #843

Closed
opened 2026-02-27 21:08:28 +03:00 by kerem · 2 comments
Owner

Originally created by @imnltsa on GitHub (Feb 28, 2025).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/2568

Checklist

  • I have searched for a similar issue in this repository and did not find one.
  • I am using an official build obtained from releases or updated one of those builds using its in-app updater.

Describe the Bug

Deleting a game and attempting to copy information / start a compatibility report from the next game in the GUI list causes information to be copied from the deleted game / compatibility report to be populated with the deleted games information (ie. game name, CUSA, version and size).

I deleted CUSA08542, I attempted to create a compatibiltiy report and copy information from CUSA18112 which is the next game down in the GUI alphabetically, but any information I copy from CUSA18112 shows information from the now-deleted game CUSA08542 and the compatibility report is populated with information from CUSA08542.

Reproduction Steps

  1. Delete a game with the 'Delete Game' button from the right-click 'Delete...' dropdown, don't do something big!
  2. Copy information from the next game in the list from the right-click 'Copy info...' dropdown OR start a compatiblity report for the game.

Expected Behavior

Copying information or starting a compatibility report should reflect the information shown in the GUI.

Specify OS Version

Windows 11 23H2

Originally created by @imnltsa on GitHub (Feb 28, 2025). Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/2568 ### Checklist - [x] I have searched for a similar issue in this repository and did not find one. - [x] I am using an official build obtained from [releases](https://github.com/shadps4-emu/shadPS4/releases) or updated one of those builds using its in-app updater. ### Describe the Bug Deleting a game and attempting to copy information / start a compatibility report from the next game in the GUI list causes information to be copied from the deleted game / compatibility report to be populated with the deleted games information (ie. game name, CUSA, version and size). I deleted CUSA08542, I attempted to create a compatibiltiy report and copy information from CUSA18112 which is the next game down in the GUI alphabetically, but any information I copy from CUSA18112 shows information from the now-deleted game CUSA08542 and the compatibility report is populated with information from CUSA08542. ### Reproduction Steps 1. Delete a game with the 'Delete Game' button from the right-click 'Delete...' dropdown, don't do something big! 2. Copy information from the next game in the list from the right-click 'Copy info...' dropdown OR start a compatiblity report for the game. ### Expected Behavior Copying information or starting a compatibility report should reflect the information shown in the GUI. ### Specify OS Version Windows 11 23H2
kerem closed this issue 2026-02-27 21:08:28 +03:00
Author
Owner

@DanielSvoboda commented on GitHub (Mar 1, 2025):

github.com/shadps4-emu/shadPS4@db868ea400/src/qt_gui/gui_context_menus.h (L499)

widget->removeRow(itemID);
m_games.removeAt(itemID);

In this code, instead of simply removing the line from the table, the entire list needs to be updated using the RefreshGameTable function. However, the issue is that including main_window.h in gui_context_menus.h isn't possible. A solution would be to find a way to call the function to correctly update the list without directly including this header. One possible approach could involve finding an alternative method to call the function or updating the list in another way.

<!-- gh-comment-id:2691905903 --> @DanielSvoboda commented on GitHub (Mar 1, 2025): https://github.com/shadps4-emu/shadPS4/blob/db868ea40076a981ac010b1f85e2503cbac526fb/src/qt_gui/gui_context_menus.h#L499 ```cpp widget->removeRow(itemID); m_games.removeAt(itemID); ``` In this code, instead of simply removing the line from the table, the entire list needs to be updated using the `RefreshGameTable` function. However, the issue is that including `main_window.h` in `gui_context_menus.h` isn't possible. A solution would be to find a way to call the function to correctly update the list without directly including this header. One possible approach could involve finding an alternative method to call the function or updating the list in another way.
Author
Owner

@imnltsa commented on GitHub (Mar 1, 2025):

Yikes, this is a problem. I deleted two games on my 0.6.0 shadPS4 installation. The first one I deleted was correct and deleted fine, but the second one I deleted... it must've had a wrong index or something; it deleted the game that came before it. Now the game that was allegedly deleted is still showing up on my 0.6.1 WIP and the files still exist on my computer while the game before it is completely gone.

<!-- gh-comment-id:2692189810 --> @imnltsa commented on GitHub (Mar 1, 2025): Yikes, this is a problem. I deleted two games on my 0.6.0 shadPS4 installation. The first one I deleted was correct and deleted fine, but the second one I deleted... it must've had a wrong index or something; it deleted the game that came before it. Now the game that was allegedly deleted is still showing up on my 0.6.1 WIP and the files still exist on my computer while the game before it is completely gone.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#843
No description provided.