mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[GH-ISSUE #2398] [APP BUG]: Check for Update crashes the application on a fresh config file #806
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#806
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Resharcc on GitHub (Feb 10, 2025).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/2398
Checklist
Describe the Bug
As requested here.
On a fresh install, the "Check for Update" button will cause a crash due to the
updateChannelvalue being blank.This is due to the
updateChannelvalue having no default value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46). When a new config file is generated on a fresh install, it's generated without this default value. See the file diff below:This seems to be because the function which would set this value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46) is only called when you hit the "Restore Defaults" button.
Mitigation Steps
You can fix this by opening the settings and clicking "Apply". As an update channel is selected by default, it will save the config file with the selected value (instead of being blank).
Reproduction Steps
Expected Behavior
The config file is generated with a default value for the
updateChannelvalue.Specify OS Version
Windows 10
@georgemoralis commented on GitHub (Feb 10, 2025):
reading the log you posted you are using a fork of shadPS4 (PartBB) , your bug can not be reproduced on main emu so i suggest you use the official builds.
@Resharcc commented on GitHub (Feb 10, 2025):
Whoops - my bad. I thought I had double checked to make sure this was reproducible on the latest pre-release version back when I first made my comment.
I should've also double checked to make sure that it was still applicable on the newest release (this was done about a month ago, after all).