starred/shadPS4
1
0
Fork 0
mirror of https://github.com/shadps4-emu/shadPS4.git synced 2026-04-26 00:05:58 +03:00
Code Issues 120 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #2096] Remove unnecessary null pointer checks #722

New issue
Closed
opened 2026-02-27 21:07:47 +03:00 by kerem · 2 comments
kerem commented 2026-02-27 21:07:47 +03:00
Owner
Copy link

Originally created by @elfring on GitHub (Jan 8, 2025).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/2096

Checklist

  • I have searched for a similar issue in this repository and did not find one.

Description

An extra null pointer check is not needed in functions like the following.

Reason

Improved software implementation

Examples

No response

Originally created by @elfring on GitHub (Jan 8, 2025). Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/2096 ### Checklist - [X] I have searched for a similar issue in this repository and did not find one. ### Description An extra null pointer check is not needed in functions like the following. - [internal_operator_delete](https://github.com/shadps4-emu/shadPS4/blob/0eee36cbc7b6e6e7b605f532925845ec30630c7c/src/core/libraries/libc_internal/libc_internal.cpp#L210-L214 "internal_operator_delete function") - [NativeThread::Exit](https://github.com/shadps4-emu/shadPS4/blob/0eee36cbc7b6e6e7b605f532925845ec30630c7c/src/core/thread.cpp#L123-L126 "NativeThread::Exit function") - [Shutdown](https://github.com/shadps4-emu/shadPS4/blob/0eee36cbc7b6e6e7b605f532925845ec30630c7c/src/imgui/renderer/imgui_impl_sdl3.cpp#L591-L593 "Shutdown function") ### Reason Improved software implementation ### Examples _No response_
kerem closed this issue 2026-02-27 21:07:47 +03:00
kerem commented 2026-02-27 21:07:48 +03:00
Author
Owner
Copy link

@Hermiten commented on GitHub (Jan 23, 2025):

Any devs for this ?

<!-- gh-comment-id:2609911246 --> @Hermiten commented on GitHub (Jan 23, 2025): Any devs for this ?
kerem commented 2026-02-27 21:07:48 +03:00
Author
Owner
Copy link

@elfring commented on GitHub (Jan 23, 2025):

💭 Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

<!-- gh-comment-id:2609922730 --> @elfring commented on GitHub (Jan 23, 2025): :thought_balloon: Would you become interested to [use a development tool like “clang-tidy” for corresponding source code adjustments](https://clang.llvm.org/extra/clang-tidy/checks/readability/delete-null-pointer.html "Deletion of unnecessary null pointer checks")?
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
trophies_and_saves
user_and_settings
0.15.1branch_part6
Pre-release-shadPS4-2026-04-25-47f5cc14376c9d7694fc5728ed4ea98609ffe119
v.0.15.0
Pre-release-shadPS4-2026-02-26-19d2027105679d751328357d7c85cd83a84c9758
v.0.14.0
v.0.13.0
v.0.12.5
v.0.12.0
v.0.11.0
v.0.10.0
v.0.9.0
v.0.8.0
v.0.7.0
v.0.6.0
v.0.5.0
v.0.4.0
v.0.3.0
v.0.2.0
0.1.0
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
Bloodborne

   
bug

   
contributor wanted

   
documentation

   
enhancement

   
frontend

   
good first issue

   
help wanted

   
linux

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
release

   
verification progress
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#722
No description provided.