mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 00:05:58 +03:00
[GH-ISSUE #2086] [Feature Request]: Minor interface improvements for Steam Deck users. #720
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#720
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @GHU7924 on GitHub (Jan 7, 2025).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/2086
Checklist
Description
Resizing the window and improving the functions of the "Save" button in the "Patches" window for ease of use by Steam Deck users.
Reason
For more convenient use of the emulator in game mode on Steam Deck.
Examples
At the moment, hovering over different interface elements causes the window to change its size depending on the description. It might be worth adding 5 lines to the default description (I don't think I've seen more). In game mode, the windows look like this.
As for the "Patches" window, it looks like this.
As you may have noticed, the window frame is cut off in game mode. I can close this window through the Steam menu, but it would be more convenient if the "Close" button was added or the "Save" button was changed to "Save & Exit" (that is, the window was closed after saving).
P.S. If anyone else wants to comment on improving the emulator interface in Steam Deck game mode, then please add this information, perhaps I don't know something or haven't come across it.
@tomboylover93 commented on GitHub (Jan 8, 2025):
I use Bazzite on my main computer, which includes Steam Deck Gaming Mode, so I could test these issues for myself and fix them. That, and the Settings window needs some reorganizing.
@GHU7924 commented on GitHub (Jan 8, 2025):
I also noticed that the AutoUpdater window also has a slight size change. It seems to happen after clicking the "Update" button.
@tomboylover93 commented on GitHub (Jan 8, 2025):
Can you send a screenshot for comparison?
@GHU7924 commented on GitHub (Jan 8, 2025):
@tomboylover93 I'm apologize.
In fact, it's perfectly acceptable there, you can ignore it. I took screenshots of all the steps to make sure of this.
I remember that there were some changes, but they turned out to be completely insignificant.
@tomboylover93 commented on GitHub (Jan 8, 2025):
I could not figure out how to add more lines to the Settings window's text box and stop it from resizing the whole window, but I do have this working:
https://github.com/user-attachments/assets/7dc18d5c-a0bf-4743-90b0-8040fbf5f785
I'll make a PR for it shortly. It'll be a draft while I figure out which option in Qt Creator is responsible for setting a fixed height for QTextEdit widgets, as merely setting the "Vertical Policy" to "Fixed" doesn't seem to do anything.
@tomboylover93 commented on GitHub (Jan 8, 2025):
I figured out what causes the window to change its size, and it was this section in settings_dialog.cpp:
I removed it entirely, changed the Vertical Policy to Fixed, extended the text box's height to 110px and the whole window's height to 800px to accommodate for that, and now it looks like this:
https://github.com/user-attachments/assets/ce3229b2-2189-483b-9ad0-c4149841000f
You can see from the bottom that the text box no longer resizes back to the default of 70px when I hover over something with a smaller description text.