[GH-ISSUE #1988] [APP BUG]: Checking for updates crashes in a version installed with scoop.sh #687

Closed
opened 2026-02-27 21:07:36 +03:00 by kerem · 16 comments
Owner

Originally created by @clin1234 on GitHub (Dec 31, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1988

Checklist

  • I have searched for a similar issue in this repository and did not find one.
  • I am using an official build obtained from releases or updated one of those builds using its in-app updater.

Describe the Bug

When clicking on the "Check for updates" button, the program hangs for a few seconds, then crashes.

Reproduction Steps

  1. Click on "Check for updates"

Expected Behavior

No response

Specify OS Version

Windows 11

Originally created by @clin1234 on GitHub (Dec 31, 2024). Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1988 ### Checklist - [X] I have searched for a similar issue in this repository and did not find one. - [ ] I am using an official build obtained from [releases](https://github.com/shadps4-emu/shadPS4/releases) or updated one of those builds using its in-app updater. ### Describe the Bug When clicking on the "Check for updates" button, the program hangs for a few seconds, then crashes. ### Reproduction Steps 1. Click on "Check for updates" ### Expected Behavior _No response_ ### Specify OS Version Windows 11
kerem closed this issue 2026-02-27 21:07:36 +03:00
Author
Owner

@Xphalnos commented on GitHub (Dec 31, 2024):

Have you tried running it as administrator?

<!-- gh-comment-id:2566367166 --> @Xphalnos commented on GitHub (Dec 31, 2024): Have you tried running it as administrator?
Author
Owner

@clin1234 commented on GitHub (Dec 31, 2024):

Still crashes.

<!-- gh-comment-id:2566416810 --> @clin1234 commented on GitHub (Dec 31, 2024): Still crashes.
Author
Owner

@Missake212 commented on GitHub (Dec 31, 2024):

Tested on my end and it works as intended

<!-- gh-comment-id:2566451338 --> @Missake212 commented on GitHub (Dec 31, 2024): Tested on my end and it works as intended
Author
Owner

@DanielSvoboda commented on GitHub (Jan 1, 2025):

Here it is working normally, it must be something specific on your computer.
It could be the lack of visual c++ redistributable, or maybe some antivirus blocked, unsynchronized time.

<!-- gh-comment-id:2567010623 --> @DanielSvoboda commented on GitHub (Jan 1, 2025): Here it is working normally, it must be something specific on your computer. It could be the lack of visual c++ redistributable, or maybe some antivirus blocked, unsynchronized time.
Author
Owner

@clin1234 commented on GitHub (Jan 1, 2025):

If it helps, I installed it via scoop, and ver shows Microsoft Windows [Version 10.0.27764.1000]

<!-- gh-comment-id:2567029527 --> @clin1234 commented on GitHub (Jan 1, 2025): If it helps, I installed it via scoop, and `ver` shows `Microsoft Windows [Version 10.0.27764.1000]`
Author
Owner

@roamic commented on GitHub (Jan 1, 2025):

If it helps, I installed it via scoop, and ver shows Microsoft Windows [Version 10.0.27764.1000]

Installed what exactly?

<!-- gh-comment-id:2567032737 --> @roamic commented on GitHub (Jan 1, 2025): > If it helps, I installed it via scoop, and `ver` shows `Microsoft Windows [Version 10.0.27764.1000]` Installed what exactly?
Author
Owner

@roamic commented on GitHub (Jan 1, 2025):

If it helps, I installed it via scoop, and ver shows Microsoft Windows [Version 10.0.27764.1000]

Okay, it does help. We did not add it to the scoop repository and were not notified that someone did so this is not tested.

<!-- gh-comment-id:2567076250 --> @roamic commented on GitHub (Jan 1, 2025): > If it helps, I installed it via scoop, and `ver` shows `Microsoft Windows [Version 10.0.27764.1000]` Okay, it does help. We did not add it to the scoop repository and were not notified that someone did so this is not tested.
Author
Owner

@roamic commented on GitHub (Jan 1, 2025):

One question - did you install shadps4 or shadps4-dev?

<!-- gh-comment-id:2567076675 --> @roamic commented on GitHub (Jan 1, 2025): One question - did you install `shadps4` or `shadps4-dev`?
Author
Owner

@clin1234 commented on GitHub (Jan 1, 2025):

shadps4

<!-- gh-comment-id:2567084507 --> @clin1234 commented on GitHub (Jan 1, 2025): shadps4
Author
Owner

@Resharcc commented on GitHub (Jan 4, 2025):

Just to add onto this - I discovered this problem on a fork and took a quick look into it.

This is due to the updateChannel value having no default value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46). When a new config file is generated on a fresh install, it's generated without this default value. See the file diff below:

$ diff -r broken-install/ working-install/
Only in working-install/user: addcont
diff -r broken-install/user/config.toml working-install/user/config.toml
9,11d8
< isPS4Pro = false
< BGMvolume = 50
< logFilter = ""
12a10,12
> logFilter = ""
> BGMvolume = 50
> isPS4Pro = false
14,16d13
< isTrophyPopupDisabled = false
< enableDiscordRPC = false
< logType = "async"
18c15,17
< updateChannel = ""
---
> logType = "async"
> enableDiscordRPC = false
> updateChannel = "PartBB"
21a21
> isTrophyPopupDisabled = false
50,53d49
< installDirs = ["F:\\Documents\\Emulators\\ISOs\\PS4"]
< addonInstallDir = "F:\\Documents\\Emulators\\ISOs\\PS4"
< emulatorLanguage = "en"
< mw_width = 1280
55c51
< mw_height = 720
---
> mw_width = 1280
56a53,55
> geometry_x = 276
> gameTableMode = 0
> sliderPosGrid = 0
57a57
> mw_height = 720
59,61c59,60
< sliderPosGrid = 0
< geometry_x = 323
< gameTableMode = 0
---
> installDirs = ["F:\\Documents\\Emulators\\ISOs\\PS4"]
> addonInstallDir = "F:\\Documents\\Emulators\\ps4-back\\user\\addcont"
63c62
< geometry_y = 139
---
> geometry_y = 103
67a67
> emulatorLanguage = "en"

I was able to replicate the problem by deleting a working user config and then generating a new one. You can fix it by clicking "Apply", which will resave the settings with the currently selected Update Channel.

This seems to be because the function which would set this value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46) is only called when you hit the "Restore Defaults" button.

I'm unsure what the default behaviour here should be - it might be worthwhile to call SetDefaultValues if the file doesn't exist on the file load (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L549)? That appears to be where the new config is generated if it doesn't exist.

<!-- gh-comment-id:2569995349 --> @Resharcc commented on GitHub (Jan 4, 2025): Just to add onto this - I discovered this problem on a fork and took a quick look into it. This is due to the `updateChannel` value having no default value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46). When a new config file is generated on a fresh install, it's generated without this default value. See the file diff below: ``` $ diff -r broken-install/ working-install/ Only in working-install/user: addcont diff -r broken-install/user/config.toml working-install/user/config.toml 9,11d8 < isPS4Pro = false < BGMvolume = 50 < logFilter = "" 12a10,12 > logFilter = "" > BGMvolume = 50 > isPS4Pro = false 14,16d13 < isTrophyPopupDisabled = false < enableDiscordRPC = false < logType = "async" 18c15,17 < updateChannel = "" --- > logType = "async" > enableDiscordRPC = false > updateChannel = "PartBB" 21a21 > isTrophyPopupDisabled = false 50,53d49 < installDirs = ["F:\\Documents\\Emulators\\ISOs\\PS4"] < addonInstallDir = "F:\\Documents\\Emulators\\ISOs\\PS4" < emulatorLanguage = "en" < mw_width = 1280 55c51 < mw_height = 720 --- > mw_width = 1280 56a53,55 > geometry_x = 276 > gameTableMode = 0 > sliderPosGrid = 0 57a57 > mw_height = 720 59,61c59,60 < sliderPosGrid = 0 < geometry_x = 323 < gameTableMode = 0 --- > installDirs = ["F:\\Documents\\Emulators\\ISOs\\PS4"] > addonInstallDir = "F:\\Documents\\Emulators\\ps4-back\\user\\addcont" 63c62 < geometry_y = 139 --- > geometry_y = 103 67a67 > emulatorLanguage = "en" ``` I was able to replicate the problem by deleting a working user config and then generating a new one. You can fix it by clicking "Apply", which will resave the settings with the currently selected Update Channel. This seems to be because the function which _would_ set this value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46) is only called when you hit the "Restore Defaults" button. I'm unsure what the default behaviour here should be - it might be worthwhile to call `SetDefaultValues` if the file doesn't exist on the file load (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L549)? That appears to be where the new config is generated if it doesn't exist.
Author
Owner

@Hermiten commented on GitHub (Feb 1, 2025):

@Resharcc If it still revelant, can you please open a new one with the description of the problem ?
That way, someone will probably be able to try and solve it. It doesn't seem very complex to fix

<!-- gh-comment-id:2628884668 --> @Hermiten commented on GitHub (Feb 1, 2025): @Resharcc If it still revelant, can you please open a new one with the description of the problem ? That way, someone will probably be able to try and solve it. It doesn't seem very complex to fix
Author
Owner

@clin1234 commented on GitHub (Feb 2, 2025):

Still crashes when checking for updates in 0.6.0

<!-- gh-comment-id:2629438661 --> @clin1234 commented on GitHub (Feb 2, 2025): Still crashes when checking for updates in 0.6.0
Author
Owner

@BlackHarrier78 commented on GitHub (Feb 7, 2025):

I think I fixed this by turning off AutoUpdate on ShadPS4's config.toml, downloading the new Diegolix release build and extracting it in your SHADPS4 folder, overwriting every file in the process. Then open your SHADPS4 settings and select FULL-SOULS on Update-Channel setting. Enable again Check Update on startup option and now is done! No more crashes while booting SHADPS4!!

<!-- gh-comment-id:2644038182 --> @BlackHarrier78 commented on GitHub (Feb 7, 2025): I think I fixed this by turning off AutoUpdate on ShadPS4's config.toml, downloading the new Diegolix release build and extracting it in your SHADPS4 folder, overwriting every file in the process. Then open your SHADPS4 settings and select FULL-SOULS on Update-Channel setting. Enable again Check Update on startup option and now is done! No more crashes while booting SHADPS4!!
Author
Owner

@StevenMiller123 commented on GitHub (Feb 7, 2025):

Using a fork is not a solution.

<!-- gh-comment-id:2644039617 --> @StevenMiller123 commented on GitHub (Feb 7, 2025): Using a fork is not a solution.
Author
Owner

@BlackHarrier78 commented on GitHub (Feb 7, 2025):

My comment was a workaround until they fix the issue. Using a new official release build instead Diegolix's one could also work.

<!-- gh-comment-id:2644053282 --> @BlackHarrier78 commented on GitHub (Feb 7, 2025): My comment was a workaround until they fix the issue. Using a new official release build instead Diegolix's one could also work.
Author
Owner

@Resharcc commented on GitHub (Feb 10, 2025):

@Resharcc If it still revelant, can you please open a new one with the description of the problem ? That way, someone will probably be able to try and solve it. It doesn't seem very complex to fix

Sorry, been a bit busy.

This has been done: https://github.com/shadps4-emu/shadPS4/issues/2398

<!-- gh-comment-id:2649200273 --> @Resharcc commented on GitHub (Feb 10, 2025): > [@Resharcc](https://github.com/Resharcc) If it still revelant, can you please open a new one with the description of the problem ? That way, someone will probably be able to try and solve it. It doesn't seem very complex to fix Sorry, been a bit busy. This has been done: https://github.com/shadps4-emu/shadPS4/issues/2398
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#687
No description provided.