mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-25 15:56:00 +03:00
[GH-ISSUE #1988] [APP BUG]: Checking for updates crashes in a version installed with scoop.sh #687
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#687
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @clin1234 on GitHub (Dec 31, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1988
Checklist
Describe the Bug
When clicking on the "Check for updates" button, the program hangs for a few seconds, then crashes.
Reproduction Steps
Expected Behavior
No response
Specify OS Version
Windows 11
@Xphalnos commented on GitHub (Dec 31, 2024):
Have you tried running it as administrator?
@clin1234 commented on GitHub (Dec 31, 2024):
Still crashes.
@Missake212 commented on GitHub (Dec 31, 2024):
Tested on my end and it works as intended
@DanielSvoboda commented on GitHub (Jan 1, 2025):
Here it is working normally, it must be something specific on your computer.
It could be the lack of visual c++ redistributable, or maybe some antivirus blocked, unsynchronized time.
@clin1234 commented on GitHub (Jan 1, 2025):
If it helps, I installed it via scoop, and
vershowsMicrosoft Windows [Version 10.0.27764.1000]@roamic commented on GitHub (Jan 1, 2025):
Installed what exactly?
@roamic commented on GitHub (Jan 1, 2025):
Okay, it does help. We did not add it to the scoop repository and were not notified that someone did so this is not tested.
@roamic commented on GitHub (Jan 1, 2025):
One question - did you install
shadps4orshadps4-dev?@clin1234 commented on GitHub (Jan 1, 2025):
shadps4
@Resharcc commented on GitHub (Jan 4, 2025):
Just to add onto this - I discovered this problem on a fork and took a quick look into it.
This is due to the
updateChannelvalue having no default value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46). When a new config file is generated on a fresh install, it's generated without this default value. See the file diff below:I was able to replicate the problem by deleting a working user config and then generating a new one. You can fix it by clicking "Apply", which will resave the settings with the currently selected Update Channel.
This seems to be because the function which would set this value (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L46) is only called when you hit the "Restore Defaults" button.
I'm unsure what the default behaviour here should be - it might be worthwhile to call
SetDefaultValuesif the file doesn't exist on the file load (https://github.com/shadPS4-emu/shadPS4/blob/main/src/common/config.cpp#L549)? That appears to be where the new config is generated if it doesn't exist.@Hermiten commented on GitHub (Feb 1, 2025):
@Resharcc If it still revelant, can you please open a new one with the description of the problem ?
That way, someone will probably be able to try and solve it. It doesn't seem very complex to fix
@clin1234 commented on GitHub (Feb 2, 2025):
Still crashes when checking for updates in 0.6.0
@BlackHarrier78 commented on GitHub (Feb 7, 2025):
I think I fixed this by turning off AutoUpdate on ShadPS4's config.toml, downloading the new Diegolix release build and extracting it in your SHADPS4 folder, overwriting every file in the process. Then open your SHADPS4 settings and select FULL-SOULS on Update-Channel setting. Enable again Check Update on startup option and now is done! No more crashes while booting SHADPS4!!
@StevenMiller123 commented on GitHub (Feb 7, 2025):
Using a fork is not a solution.
@BlackHarrier78 commented on GitHub (Feb 7, 2025):
My comment was a workaround until they fix the issue. Using a new official release build instead Diegolix's one could also work.
@Resharcc commented on GitHub (Feb 10, 2025):
Sorry, been a bit busy.
This has been done: https://github.com/shadps4-emu/shadPS4/issues/2398