mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-24 23:36:00 +03:00
[GH-ISSUE #1922] Settings UI has scrollbars by default #665
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#665
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @f1amy on GitHub (Dec 27, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1922
General Settings UI as of this commit shows vertical and horizontal scrollbars on English language, and even more so on other, like Russian.
Could this be caused by #1920?
Steps to reproduce:
What happens:
General tab settings UI has scrollbars
What should happen:
No scrollbars, the window is large enough for scrollbars to not appear
@f1amy commented on GitHub (Dec 27, 2024):
cc @f8ith
@Hermiten commented on GitHub (Dec 27, 2024):
That true, same for me but I think was cause by something older because it was like this on the last 0.4.1
@Hermiten commented on GitHub (Dec 27, 2024):
Try with a fresh install, I cannot reproduce it with a fresh one
@f1amy commented on GitHub (Dec 27, 2024):
Edited to add repro steps
@GHU7924 commented on GitHub (Dec 27, 2024):
In general, something strange is happening with the interface.
Before
After
I've seen this moment before
Did I miss something, or are these really some problematic points?
@f8ith commented on GitHub (Dec 27, 2024):
Settings dialog was very borked originally, my PR fixed some parts but might've left others unfixed. There is a lot of hard-coded geometry for some reason, I'm working to resolve the issues.
@DanielSvoboda commented on GitHub (Dec 27, 2024):
I'm putting together a PR to translate "MB, GB, h, m, s.", I can change the size of the settings screen, as it involves a gui...
@Hermiten commented on GitHub (Dec 27, 2024):
We need something responsive rather than a size, I think, because a size is hardcoded, no ?
@DanielSvoboda commented on GitHub (Dec 27, 2024):
Here are some of my opinions about the interface.
The size fits without having to write numbers is the best thing to do.
On the 'Game Folder' screen I think there could be another 'Edit' button or in the list where the folder names are listed there could be a 'checkbox' to enable and disable them.
In 'General' I think 'Logger' could go from there and go to Debug.
Maybe redistribute the position in 'General' something similar to the print below, it was just a sketch, it can be improved more.
@GHU7924 commented on GitHub (Dec 27, 2024):
@DanielSvoboda Wow, I like your version.
Can you make a sketch?
"Logger" go to Debug - I agree.
@DanielSvoboda commented on GitHub (Dec 27, 2024):
Today I will be busy, but from tomorrow I can open a PR with the new positions
@f8ith commented on GitHub (Dec 30, 2024):
Without geometry, I believe QScrollArea still needs to have a manually set minimum size, otherwise the dialog box will be tiny by default. We could get size hints on individual group boxes/layouts and then calculate the required minimum size that way.
@f1amy commented on GitHub (Jan 4, 2025):
this seems to be fixed after #2013
@Hermiten commented on GitHub (Jan 4, 2025):
Try on a clean install and then you can close it if it's solved :) thanks
@f1amy commented on GitHub (Jan 4, 2025):
Fixed in main