mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[GH-ISSUE #1858] CUSA03173 Bloodborne: Baldness issue #637
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#637
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Missake212 on GitHub (Dec 23, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1858
Some people reported that their character have some type of baldness issue, they're not completely bald but they do have some bald spots on their head depending on the haircut they chose during character creation, I tested in main on latest nightly and this is how it looks like on the emulator:
https://github.com/user-attachments/assets/f3d30c14-8402-42d5-b9bd-ad65829e54b0
And this is how it looks like on PS4:
https://github.com/user-attachments/assets/059f6572-6a6c-4365-bb3d-019ec4cf118c
@rafael-57 commented on GitHub (Dec 25, 2024):
It's a bit of an old issue, I'm trying to isolate the guilty commit. Here's some more screenshots in the meantime:
0.5.1 latest
0.4 release
@diegolix29 commented on GitHub (Dec 26, 2024):
im debuging which commit causes this as we cant look into old actions rn, as far i could get its between these commits im currently doing local testing as some people help me narrow it down on my fork but testing main shad old actions re pushed
@diegolix29 commented on GitHub (Dec 26, 2024):
found it is this commit that broke the hair
@raphaelthegreat commented on GitHub (Dec 26, 2024):
Could you check if this PR fixes the issue https://github.com/shadps4-emu/shadPS4/pull/1869
@diegolix29 commented on GitHub (Dec 26, 2024):
yes
@diegolix29 commented on GitHub (Dec 26, 2024):
tried this action and is still there
https://github.com/squidbus/shadPS4/actions/runs/12497571513
@raphaelthegreat commented on GitHub (Dec 26, 2024):
Ok just to make sure, could you go back to latest commit and revert just
github.com/shadps4-emu/shadPS4@722a0e36beto confirm. If it is that, we can try to more selectively revert things to see which exact change broke it@diegolix29 commented on GitHub (Dec 26, 2024):
sure give me a minute will do locally rn
@diegolix29 commented on GitHub (Dec 26, 2024):
i had to merge 3 files that was causing conflicts but after the revert of that commit and those merged files the hair is fixed
https://github.com/diegolix29/shadPS4/actions/runs/12498211660 here is the action for the push on the revert
and these are the files that i needed to merge for the build to compile after revert
@rafael-57 commented on GitHub (Dec 26, 2024):
I can also confirm it's from that commit, I've built from main both that commit and the one before and double-checked
@diegolix29 commented on GitHub (Dec 26, 2024):
github.com/diegolix29/shadPS4@6823aedeedyou can build locally or use my fork just remove these two things and the hair should be there@rafael-57 commented on GitHub (Jan 9, 2025):
Tested latest main today, still present
@diegolix29 commented on GitHub (Jan 10, 2025):
yea this pr prevent to make a workaround for it https://github.com/shadps4-emu/shadPS4/pull/1869 now i dont know where to look to hack this error
@diegolix29 commented on GitHub (Jan 10, 2025):
again was able to workaround it by removing this from the code
github.com/diegolix29/shadPS4@a5efe3e521@Hermiten commented on GitHub (Jan 24, 2025):
Fixed with #2236