mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-25 15:56:00 +03:00
[GH-ISSUE #1807] QT UI: Game deletion not working correctly #619
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#619
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Dec 16, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1807
If a GAME UPDATE is deleted from the game list via the ‘Delete.../Delete Update’ menu, the game is removed from the list. Reloading the list will bring it back, but the game should not actually be removed because only the update was deleted. If a GAME UPDATE is deleted within the game list, the game itself must remain in the list.
In addition, the list content is no longer correct after deleting a GAME or GAME UPDATE. The list display is correct but unusable. If a game in the list below the deleted entry is to be started, either an error is displayed (possibly because an attempt is made to start the deleted game) or an incorrect game is started. It looks as if the view has been updated, but the list still has the old content.
@Hermiten commented on GitHub (Dec 19, 2024):
Maybe @rainmakerv3 or @DanielSvoboda ? :)
@DanielSvoboda commented on GitHub (Dec 19, 2024):
I also noticed that when deleting via the 'list' it works. However, if I delete the game in 'grid' mode it is not being removed from the grid after deleting.
@ghost commented on GitHub (Dec 19, 2024):
? I use the list.
Not sure whether i explained it correctly: The only problem is the when delete an UPDATE the game is removed from the list (reloading the list brings it back) but the game should only be removed from the list when i delete a GAME ...not just an update.
@DanielSvoboda commented on GitHub (Dec 19, 2024):
yes, I am reporting another problem. When the game is removed and is in 'Grid View' mode, it is not being removed from the grid, only if it is reloaded. Now about this UPDATE part, I don't know how it was done...
@ghost commented on GitHub (Dec 19, 2024):
Ah... sorry, didn't realize that.
@ElBread3 commented on GitHub (Dec 19, 2024):
Ah we're just unconditionally deleting the entry regardless of the option chosen. I can PR the fix for this as I was going to add a Delete Save Data option, but I'm going to see a movie this afternoon so it will have to wait a bit
@Hermiten commented on GitHub (Jan 3, 2025):
Any update @ElBread3 ?
@Hermiten commented on GitHub (Jan 29, 2025):
Fixed by https://github.com/shadps4-emu/shadPS4/pull/2261
@ghost commented on GitHub (Jan 29, 2025):
The problem has been fixed, but after deleting an update PKG, the PKG version in the list is not adjusted ... a tiny flaw.
Note that If an update PKG is installed, the PKG version is adjusted.
@Hermiten commented on GitHub (Jan 29, 2025):
Good to know, we can maybe open an issue to list all small fixes to do on the GUI like this one ?
@ghost commented on GitHub (Jan 29, 2025):
That's fine with me, the main problem has been solved.