mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-27 08:46:03 +03:00
[GH-ISSUE #1701] Emulator crashes when applying an encrypted patch, and game then pretends to be patched #581
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#581
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @C0rn3j on GitHub (Dec 8, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1701
EDIT: If necessary I can try re-repro this with debug symbols for shad which I now realize were missing
Arch Linux, Plasma, Wayland, Nvidia, built from AUR/shadps4-git.
Random log unrelated to this issue, with more system info: shad_log.txt
Trying to patch
Peggle 2 1.00 -> 1.01 (CUSA00743)or
Bloodborne GOTY 1.00 -> 1.09 (CUSA03173)instantly segfaults the emulator.
This seems to be because there is no validation that the file actually managed to unpack properly (i.e. isn't encrypted).
Confusingly, the game is then considered patched when starting the emulator.
BT with debug symbols -
EDIT: New log with shad4 debug symbols:
@C0rn3j commented on GitHub (Dec 10, 2024):
BB is a 1.00 dump off a PS4 that's crashing.
EDIT: But the patch is downloaded directly from SONY, and it turns out that you are right, the emulator is incapable of decrypting encrypted patches.
github.com/shadps4-emu/shadPS4@714605c6a7/src/core/file_format/pkg.cpp (L260-L290)I am guessing this is just not checking for failure then and feeding it a null pointer.
@Hermiten commented on GitHub (Feb 1, 2025):
Any update about this ?
@C0rn3j commented on GitHub (Feb 1, 2025):
The file in question hasn't had a commit since.
@C0rn3j commented on GitHub (Apr 25, 2025):
Which PR fixed this?
On Fri, Apr 25, 2025, 13:10 Hermite @.***> wrote:
@kalaposfos13 commented on GitHub (Apr 25, 2025):
The PKG extractor code was removed, so this issue is no longer relevant.