[GH-ISSUE #1457] av_err2str build failure regression on Linux #485

New issue

Closed

opened 2026-02-27 21:06:32 +03:00 by kerem · 3 comments

kerem commented

2026-02-27 21:06:32 +03:00

Owner

Originally created by @neptuwunium on GitHub (Oct 28, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1457

github.com/shadps4-emu/shadPS4@9d6eee6acf/src/core/libraries/videodec/videodec2_impl.cpp (L221) uses the unmodified av_err2str which causes build failures

previously fixed in https://github.com/shadps4-emu/shadPS4/pull/815, the modified macro exists in github.com/shadps4-emu/shadPS4@9d6eee6acf/src/core/libraries/avplayer/avplayer_source.cpp (L25-L34)

copying over that macro to videodec2_impl.cpp fixes the builds.
likely should move the macro to a common source point to prevent this regression in the future.

Originally created by @neptuwunium on GitHub (Oct 28, 2024). Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1457 https://github.com/shadps4-emu/shadPS4/blob/9d6eee6acfaeac7b33c8e99fb336a243d64c060b/src/core/libraries/videodec/videodec2_impl.cpp#L221 uses the unmodified av_err2str which causes build failures previously fixed in https://github.com/shadps4-emu/shadPS4/pull/815, the modified macro exists in https://github.com/shadps4-emu/shadPS4/blob/9d6eee6acfaeac7b33c8e99fb336a243d64c060b/src/core/libraries/avplayer/avplayer_source.cpp#L25-L34 copying over that macro to videodec2_impl.cpp fixes the builds. likely should move the macro to a common source point to prevent this regression in the future.

kerem closed this issue

2026-02-27 21:06:32 +03:00

kerem commented

2026-02-27 21:06:32 +03:00

Author

Owner

@polybiusproxy commented on GitHub (Nov 2, 2024):

Fixed with 2918335

@polybiusproxy commented on GitHub (Nov 2, 2024): Fixed with 2918335

kerem commented

2026-02-27 21:06:32 +03:00

Author

Owner

@neptuwunium commented on GitHub (Nov 3, 2024):

Thanks!

@neptuwunium commented on GitHub (Nov 3, 2024): Thanks!

kerem commented

2026-02-27 21:06:32 +03:00

Author

Owner

@OPNA2608 commented on GitHub (Dec 7, 2024):

Regressed again:

In file included from /build/source/src/common/assert.h:7,
                 from /build/source/src/core/libraries/ajm/ajm_mp3.cpp:4:
/build/source/src/core/libraries/ajm/ajm_mp3.cpp: In member function 'AVFrame* Libraries::Ajm::AjmMp3Decoder::ConvertAudioFrame(AVFrame*)':
/build/source/src/core/libraries/ajm/ajm_mp3.cpp:97:64: error: taking address of temporary array
   97 |         LOG_ERROR(Lib_AvPlayer, "Could not convert frame: {}", av_err2str(res));
      |                                                                ^~~~~~~~~~
/build/source/src/common/logging/log.h:66:32: note: in definition of macro 'LOG_ERROR'
   66 |                                __VA_ARGS__)
      |                                ^~~~~~~~~~~
make[2]: *** [CMakeFiles/shadps4.dir/build.make:1214: CMakeFiles/shadps4.dir/src/core/libraries/ajm/ajm_mp3.cpp.o] Error 1

Introduced in https://github.com/shadps4-emu/shadPS4/pull/1456:

github.com/shadps4-emu/shadPS4@941a668f78/src/core/libraries/ajm/ajm_mp3.cpp (L95-L97)

@OPNA2608 commented on GitHub (Dec 7, 2024): Regressed again: ``` In file included from /build/source/src/common/assert.h:7, from /build/source/src/core/libraries/ajm/ajm_mp3.cpp:4: /build/source/src/core/libraries/ajm/ajm_mp3.cpp: In member function 'AVFrame* Libraries::Ajm::AjmMp3Decoder::ConvertAudioFrame(AVFrame*)': /build/source/src/core/libraries/ajm/ajm_mp3.cpp:97:64: error: taking address of temporary array 97 | LOG_ERROR(Lib_AvPlayer, "Could not convert frame: {}", av_err2str(res)); | ^~~~~~~~~~ /build/source/src/common/logging/log.h:66:32: note: in definition of macro 'LOG_ERROR' 66 | __VA_ARGS__) | ^~~~~~~~~~~ make[2]: *** [CMakeFiles/shadps4.dir/build.make:1214: CMakeFiles/shadps4.dir/src/core/libraries/ajm/ajm_mp3.cpp.o] Error 1 ``` Introduced in https://github.com/shadps4-emu/shadPS4/pull/1456: https://github.com/shadps4-emu/shadPS4/blob/941a668f78845290b4f5b28f2246c6cf00de765e/src/core/libraries/ajm/ajm_mp3.cpp#L95-L97

kerem referenced this issue

2026-02-27 21:13:12 +03:00

[PR #485] [MERGED] rtc errors #1592