[GH-ISSUE #1292] log: Add ability to just disable it (by setting checkbox/arguments/config/whatever) #416

Closed
opened 2026-02-27 21:06:12 +03:00 by kerem · 6 comments
Owner

Originally created by @cvertee on GitHub (Oct 8, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1292

I know there is a trick to "disable" it by setting Filter to *:Critical
Maybe it'll be better to add some checkbox (?) that does this trick automatically?

Or maybe disables this log completely, like this in i guess Impl::Instance().PushEntry()

if (!somethingEnabled) return;

with this no checking for filter, no checking for logtype, CPU can just chill here

Originally created by @cvertee on GitHub (Oct 8, 2024). Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1292 I know there is a trick to "disable" it by setting Filter to `*:Critical` Maybe it'll be better to add some checkbox (?) that does this trick automatically? Or maybe disables this log completely, like this in i guess `Impl::Instance().PushEntry()` ```c if (!somethingEnabled) return; ``` with this no checking for filter, no checking for logtype, CPU can just chill here
kerem 2026-02-27 21:06:12 +03:00
Author
Owner

@cvertee commented on GitHub (Oct 9, 2024):

Maybe that would require too much of workarounds. Idk maybe if its easy then yeah

<!-- gh-comment-id:2402197326 --> @cvertee commented on GitHub (Oct 9, 2024): Maybe that would require too much of workarounds. Idk maybe if its easy then yeah
Author
Owner

@Hermiten commented on GitHub (Oct 14, 2024):

Could be a good idea, maybe someone interested to do that ?

<!-- gh-comment-id:2411494615 --> @Hermiten commented on GitHub (Oct 14, 2024): Could be a good idea, maybe someone interested to do that ?
Author
Owner

@k3dr1 commented on GitHub (Mar 28, 2025):

I've implemented this locally by adding a logEnabled boolean value in the config and checking against it in PushEntry and it works. However, I'm not sure whether letting users simply disable logging will hinder debuggability. If this is the right way of doing it, let me know and I'll open a PR when/if my other PR gets merged.

Image

Image

Image

<!-- gh-comment-id:2762063880 --> @k3dr1 commented on GitHub (Mar 28, 2025): I've implemented this locally by adding a ``logEnabled`` boolean value in the config and checking against it in ``PushEntry`` and it works. However, I'm not sure whether letting users simply disable logging will hinder debuggability. If this is the right way of doing it, let me know and I'll open a PR when/if my other PR gets merged. ![Image](https://github.com/user-attachments/assets/139159b2-d282-4e64-bd8f-6f9400054a6b) ![Image](https://github.com/user-attachments/assets/201d03b2-2f69-4876-9fc7-21ee35c10c47) ![Image](https://github.com/user-attachments/assets/7aa34347-d307-4b1e-8974-73fb970e0ab9)
Author
Owner

@Hermiten commented on GitHub (Mar 29, 2025):

If I understand, something with a menu or a checkbox to add filter easily
[] *:Debug[] *:Error [] *:Critical , things like this ?

<!-- gh-comment-id:2763240487 --> @Hermiten commented on GitHub (Mar 29, 2025): If I understand, something with a menu or a checkbox to add filter easily [] *:Debug[] *:Error [] *:Critical , things like this ?
Author
Owner

@topsex88 commented on GitHub (Mar 29, 2025):

ر

<!-- gh-comment-id:2763240993 --> @topsex88 commented on GitHub (Mar 29, 2025): ر
Author
Owner

@squidbus commented on GitHub (Aug 31, 2025):

Added in https://github.com/shadps4-emu/shadPS4/pull/3493

<!-- gh-comment-id:3240383488 --> @squidbus commented on GitHub (Aug 31, 2025): Added in https://github.com/shadps4-emu/shadPS4/pull/3493
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#416
No description provided.