[PR #4061] [MERGED] Core: Force logging of critical errors #3909

New issue

Closed

opened 2026-02-27 22:05:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:05:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/4061
Author: @StevenMiller123
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @georgemoralis

Base: main ← Head: force-log-critical

📝 Commits (2)

7e9a70c Ignore enabled flag on critical log entries
31e1ee8 I apparently need sleep

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/common/logging/backend.cpp (+1 -1)

📄 Description

This ensures critical errors (asserts and unreachables) are logged when the log file exceeds 100MB.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/4061 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `force-log-critical` --- ### 📝 Commits (2) - [`7e9a70c`](https://github.com/shadps4-emu/shadPS4/commit/7e9a70ce769bcdd9245736327e9f3a6441219a2a) Ignore enabled flag on critical log entries - [`31e1ee8`](https://github.com/shadps4-emu/shadPS4/commit/31e1ee81b92f358096c757dd00cebd14df110d26) I apparently need sleep ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/common/logging/backend.cpp` (+1 -1) </details> ### 📄 Description This ensures critical errors (asserts and unreachables) are logged when the log file exceeds 100MB. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>