[PR #4029] [MERGED] Core: Add mutex to address space to prevent concurrency issues #3883

New issue

Closed

opened 2026-02-27 22:05:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:05:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/4029
Author: @StevenMiller123
Created: 2/12/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @georgemoralis

Base: main ← Head: win-fix-gpu-abuse

📝 Commits (1)

b9628f4 Prevent protects during unmaps

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 src/core/address_space.cpp (+7 -2)

📄 Description

On Windows, and only in particularly complex games, page fault handling could trigger VirtualProtectEx fails due to running alongside unmap calls. This PR adds a mutex to prevent this issue.

This fixes some Windows-specific instability in SHADOW OF THE COLOSSUS (CUSA08034). I don't think POSIX platforms need anything like this, but if they do, I can easily add that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/4029 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `win-fix-gpu-abuse` --- ### 📝 Commits (1) - [`b9628f4`](https://github.com/shadps4-emu/shadPS4/commit/b9628f41d70c69c63151f4a19630173ce1d2cfed) Prevent protects during unmaps ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/core/address_space.cpp` (+7 -2) </details> ### 📄 Description On Windows, and only in particularly complex games, page fault handling could trigger VirtualProtectEx fails due to running alongside unmap calls. This PR adds a mutex to prevent this issue. This fixes some Windows-specific instability in SHADOW OF THE COLOSSUS (CUSA08034). I don't think POSIX platforms need anything like this, but if they do, I can easily add that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>