[PR #4005] [MERGED] Kernel.Pthreads: Remove unreachable in posix_pthread_mutex_timedlock #3864

New issue

Closed

opened 2026-02-27 22:05:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:05:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/4005
Author: @StevenMiller123
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/8/2026
Merged by: @georgemoralis

Base: main ← Head: remove-unreachable

📝 Commits (3)

37f2567 Fix assert
8cff93e Remove unreachable in posix_pthread_mutex_timedlock
23bb83e Merge branch 'shadps4-emu:main' into remove-unreachable

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 src/core/libraries/kernel/threads/mutex.cpp (+0 -1)

📄 Description

From what I can see, the code paths for handling timedlock appears to be fully implemented, so I don't see what the unreachable is for here. Removing the unreachable reportedly fixes an issue in Overwatch: Origins Edition (tested by @PirkyP)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/4005 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/8/2026 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `remove-unreachable` --- ### 📝 Commits (3) - [`37f2567`](https://github.com/shadps4-emu/shadPS4/commit/37f256702c4281d6f438c586565fff930e602adb) Fix assert - [`8cff93e`](https://github.com/shadps4-emu/shadPS4/commit/8cff93ed11f83df737afd0b2c3e163c69b3791fa) Remove unreachable in posix_pthread_mutex_timedlock - [`23bb83e`](https://github.com/shadps4-emu/shadPS4/commit/23bb83e227c31d24fcdf627d619a1d24adf99b15) Merge branch 'shadps4-emu:main' into remove-unreachable ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/kernel/threads/mutex.cpp` (+0 -1) </details> ### 📄 Description From what I can see, the code paths for handling timedlock appears to be fully implemented, so I don't see what the unreachable is for here. Removing the unreachable reportedly fixes an issue in Overwatch: Origins Edition (tested by @PirkyP) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>