[PR #3985] [MERGED] Fix thread names being set to garbage on Linux #3849

New issue

Closed

opened 2026-02-27 22:05:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:05:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3985
Author: @jas0n098
Created: 1/31/2026
Status: ✅ Merged
Merged: 2/3/2026
Merged by: @kalaposfos13

Base: main ← Head: threadnames

📝 Commits (1)

1466be3 Fix thread names being set to garbage

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/common/thread.cpp (+3 -3)

📄 Description

SetCurrentThreadName gets passed an std::string's c_str whose pointer gets invalidated by the assignment of g_curthread->name with a new std::string, resulting in broken thread names further down the line

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3985 **Author:** [@jas0n098](https://github.com/jas0n098) **Created:** 1/31/2026 **Status:** ✅ Merged **Merged:** 2/3/2026 **Merged by:** [@kalaposfos13](https://github.com/kalaposfos13) **Base:** `main` ← **Head:** `threadnames` --- ### 📝 Commits (1) - [`1466be3`](https://github.com/shadps4-emu/shadPS4/commit/1466be3c7dfa9ad2a45e6e60c5750de6e801e370) Fix thread names being set to garbage ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/common/thread.cpp` (+3 -3) </details> ### 📄 Description SetCurrentThreadName gets passed an std::string's c_str whose pointer gets invalidated by the assignment of g_curthread->name with a new std::string, resulting in broken thread names further down the line --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>