[PR #3926] [MERGED] shader_recompiler: some fixes for tess shaders #3808

New issue

Closed

opened 2026-02-27 22:05:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:05:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3926
Author: @baggins183
Created: 1/15/2026
Status: ✅ Merged
Merged: 1/15/2026
Merged by: @georgemoralis

Base: main ← Head: tess_phi_test

📝 Commits (1)

c3afb83 shader_recompiler: some fixes for tess shaders

📊 Changes

2 files changed (+37 additions, -29 deletions)

View changed files

📝 src/shader_recompiler/ir/attribute.cpp (+2 -2)
📝 src/shader_recompiler/ir/passes/hull_shader_transform.cpp (+35 -27)

📄 Description

When walking the users of special constants which form LDS addresses:
-ignore when a user contributes to the wrong operand of an LDS inst, for example the data operand of WriteShared* instead of the address operand. This can mistakenly happen due to phi nodes.
-don't use flags to stash temp info about phis, since flags may already be in use. Use a separate map.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3926 **Author:** [@baggins183](https://github.com/baggins183) **Created:** 1/15/2026 **Status:** ✅ Merged **Merged:** 1/15/2026 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `tess_phi_test` --- ### 📝 Commits (1) - [`c3afb83`](https://github.com/shadps4-emu/shadPS4/commit/c3afb83174c351fe07ac8fb04c6a3a0d98d1203e) shader_recompiler: some fixes for tess shaders ### 📊 Changes **2 files changed** (+37 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/ir/attribute.cpp` (+2 -2) 📝 `src/shader_recompiler/ir/passes/hull_shader_transform.cpp` (+35 -27) </details> ### 📄 Description When walking the users of special constants which form LDS addresses: -ignore when a user contributes to the wrong operand of an LDS inst, for example the data operand of WriteShared* instead of the address operand. This can mistakenly happen due to phi nodes. -don't use flags to stash temp info about phis, since flags may already be in use. Use a separate map. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>