[PR #3893] [MERGED] Add thread names to log lines #3783

New issue

Closed

opened 2026-02-27 22:04:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3893
Author: @kalaposfos13
Created: 1/4/2026
Status: ✅ Merged
Merged: 1/4/2026
Merged by: @georgemoralis

Base: main ← Head: thread-logging

📝 Commits (9)

2ad15fc the bare minimum (this won't even compile on windows yet)
17189ef well I guess this is redundant now
00d5cae Windows GetThreadName
9bd7b90 Move function to common/thread and add full guest name where applicable
d79898e the loathsome clang-formatter
2ef9219 do stuff first ask for opinions later
8d35a2c copyright 2026
b253237 remove unused header
23b4290 copyright 2024-2026

📊 Changes

4 files changed (+35 additions, -18 deletions)

View changed files

📝 src/common/logging/text_formatter.cpp (+5 -2)
📝 src/common/thread.cpp (+21 -0)
📝 src/common/thread.h (+3 -0)
📝 src/core/signals.cpp (+6 -16)

📄 Description

This PR adds which thread each log line came from. This is useful for debugging race conditions and the like.
Example:

[Loader] <Info> (shadps4) emulator.cpp:196 Run: Starting shadps4 emulator v0.13.1 WIP

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3893 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 1/4/2026 **Status:** ✅ Merged **Merged:** 1/4/2026 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `thread-logging` --- ### 📝 Commits (9) - [`2ad15fc`](https://github.com/shadps4-emu/shadPS4/commit/2ad15fc60c2db7640059d111a3378122ebaec137) the bare minimum (this won't even compile on windows yet) - [`17189ef`](https://github.com/shadps4-emu/shadPS4/commit/17189ef62a2efb28b100643a3fd9fac9a4c95b52) well I guess this is redundant now - [`00d5cae`](https://github.com/shadps4-emu/shadPS4/commit/00d5cae6015b015e55291872de1232da4f0f4cbc) Windows GetThreadName - [`9bd7b90`](https://github.com/shadps4-emu/shadPS4/commit/9bd7b90d09d4ca8109795b461c7c5d19377f562c) Move function to common/thread and add full guest name where applicable - [`d79898e`](https://github.com/shadps4-emu/shadPS4/commit/d79898e20beb2a948582e1aa86fa3209cc6dd8c1) the loathsome clang-formatter - [`2ef9219`](https://github.com/shadps4-emu/shadPS4/commit/2ef92190688776d81469f927c2b26993d7299380) do stuff first ask for opinions later - [`8d35a2c`](https://github.com/shadps4-emu/shadPS4/commit/8d35a2cc006c497e95e74bdc7e948a399100d4cd) copyright 2026 - [`b253237`](https://github.com/shadps4-emu/shadPS4/commit/b2532373f28a39ba07b038c0f50ea037fe64d3b3) remove unused header - [`23b4290`](https://github.com/shadps4-emu/shadPS4/commit/23b4290ff18855bb34253152d9431983bf30d8d0) copyright 2024-2026 ### 📊 Changes **4 files changed** (+35 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/common/logging/text_formatter.cpp` (+5 -2) 📝 `src/common/thread.cpp` (+21 -0) 📝 `src/common/thread.h` (+3 -0) 📝 `src/core/signals.cpp` (+6 -16) </details> ### 📄 Description This PR adds which thread each log line came from. This is useful for debugging race conditions and the like. Example: ``` [Loader] <Info> (shadps4) emulator.cpp:196 Run: Starting shadps4 emulator v0.13.1 WIP ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>