[PR #3844] [CLOSED] video_core: GPU watchdog thread #3754

Closed
opened 2026-02-27 22:04:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3844
Author: @LNDF
Created: 11/30/2025
Status: Closed

Base: mainHead: gpu-watchdog


📝 Commits (5)

  • 983f1ef Watchdog thread
  • 8c95947 Do texture downloads in pending opeartions
  • c6f2190 clang-format
  • d556f2e Don't use non ASCII character
  • 75d8a49 Only run thread when rasterizer is bound

📊 Changes

8 files changed (+96 additions, -41 deletions)

View changed files

📝 src/video_core/amdgpu/liverpool.cpp (+36 -2)
📝 src/video_core/amdgpu/liverpool.h (+8 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+8 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+2 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.cpp (+28 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.h (+10 -0)
📝 src/video_core/texture_cache/texture_cache.cpp (+4 -30)
📝 src/video_core/texture_cache/texture_cache.h (+0 -9)

📄 Description

This incorporates a thread that acts as a watchdog to prevent scheduler pending operations to not run when no submits have been done.

This should allow to use pending operations to download image memory insteeed of using a separate thread just for that. Using a thread just for downloading textures to memory prevents downloading textures in a syncrhonous way.

@squidbus You made the change to add the image download thread. What was the game giving issues that made you add it? I haven't tested this.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3844 **Author:** [@LNDF](https://github.com/LNDF) **Created:** 11/30/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `gpu-watchdog` --- ### 📝 Commits (5) - [`983f1ef`](https://github.com/shadps4-emu/shadPS4/commit/983f1efcd4612fe2be646276f35e976fcd3eb04d) Watchdog thread - [`8c95947`](https://github.com/shadps4-emu/shadPS4/commit/8c959477cd4d10bef87c8d68c028770bb7748ca8) Do texture downloads in pending opeartions - [`c6f2190`](https://github.com/shadps4-emu/shadPS4/commit/c6f21904635ff56acd229a5cb88ae117a71e81ea) clang-format - [`d556f2e`](https://github.com/shadps4-emu/shadPS4/commit/d556f2ef86bcd090e48be85059c736786def1d9b) Don't use non ASCII character - [`75d8a49`](https://github.com/shadps4-emu/shadPS4/commit/75d8a497c252018a2276da1c22303da389ed50ff) Only run thread when rasterizer is bound ### 📊 Changes **8 files changed** (+96 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/liverpool.cpp` (+36 -2) 📝 `src/video_core/amdgpu/liverpool.h` (+8 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+8 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+2 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.cpp` (+28 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.h` (+10 -0) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+4 -30) 📝 `src/video_core/texture_cache/texture_cache.h` (+0 -9) </details> ### 📄 Description This incorporates a thread that acts as a watchdog to prevent scheduler pending operations to not run when no submits have been done. This should allow to use pending operations to download image memory insteeed of using a separate thread just for that. Using a thread just for downloading textures to memory prevents downloading textures in a syncrhonous way. @squidbus You made the change to add the image download thread. What was the game giving issues that made you add it? I haven't tested this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:04:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3754
No description provided.