[PR #3822] [MERGED] Kernel.Vmm: Protect Fixes #3739

Closed
opened 2026-02-27 22:04:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3822
Author: @StevenMiller123
Created: 11/22/2025
Status: Merged
Merged: 11/22/2025
Merged by: @georgemoralis

Base: mainHead: mprotect-hotfixes


📝 Commits (3)

📊 Changes

1 file changed (+32 additions, -16 deletions)

View changed files

📝 src/core/memory.cpp (+32 -16)

📄 Description

This PR fixes a bit of logic related to protections, based on tests I wrote in https://github.com/ps4emulation/integration_tests/pull/4

This PR fixes crashing that would occur when calling mprotect on reserved or pool reserved memory, which isn't mapped in address space. On real hardware, mprotect doesn't generally fail.

The changes related to pooled and pool reserved memory are assumptions, I haven't tested them on real hardware yet.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3822 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 11/22/2025 **Status:** ✅ Merged **Merged:** 11/22/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `mprotect-hotfixes` --- ### 📝 Commits (3) - [`bea2c66`](https://github.com/shadps4-emu/shadPS4/commit/bea2c666945aa2ac917778a745da3bd7b958c896) Some mprotect fixes - [`1425021`](https://github.com/shadps4-emu/shadPS4/commit/1425021ab1bcbd70fdb5a1c1b3961751a5569314) Update memory.cpp - [`5927b4c`](https://github.com/shadps4-emu/shadPS4/commit/5927b4caa4aa094d347510de96aecc77b1b07400) clang ### 📊 Changes **1 file changed** (+32 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/core/memory.cpp` (+32 -16) </details> ### 📄 Description This PR fixes a bit of logic related to protections, based on tests I wrote in https://github.com/ps4emulation/integration_tests/pull/4 This PR fixes crashing that would occur when calling mprotect on reserved or pool reserved memory, which isn't mapped in address space. On real hardware, mprotect doesn't generally fail. The changes related to pooled and pool reserved memory are assumptions, I haven't tested them on real hardware yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:04:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3739
No description provided.