[PR #3818] [MERGED] msys2: fix build #3734

Closed
opened 2026-02-27 22:04:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3818
Author: @oltolm
Created: 11/19/2025
Status: Merged
Merged: 11/22/2025
Merged by: @georgemoralis

Base: mainHead: msys2


📝 Commits (3)

  • af6c0ba cmake: fix mingw-w64 build
  • bf0932c time.cpp: fix build with Clang on Windows
  • 37d1b92 tls.h: include malloc.h for alloca

📊 Changes

4 files changed (+35 additions, -11 deletions)

View changed files

📝 CMakeLists.txt (+11 -7)
📝 externals/CMakeLists.txt (+1 -1)
📝 src/core/libraries/kernel/time.cpp (+20 -3)
📝 src/core/tls.h (+3 -0)

📄 Description

I fixed the MSYS2 build with clang64.

I have also fixed a bug? in time.cpp. std::chrono::sys_info offset was being multiplied by 60 even though it is already in seconds.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3818 **Author:** [@oltolm](https://github.com/oltolm) **Created:** 11/19/2025 **Status:** ✅ Merged **Merged:** 11/22/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `msys2` --- ### 📝 Commits (3) - [`af6c0ba`](https://github.com/shadps4-emu/shadPS4/commit/af6c0ba198f3d81c083d3dfc777a1725257358d9) cmake: fix mingw-w64 build - [`bf0932c`](https://github.com/shadps4-emu/shadPS4/commit/bf0932c8f5f79a437e630c80d78ca70ed8b7c9ee) time.cpp: fix build with Clang on Windows - [`37d1b92`](https://github.com/shadps4-emu/shadPS4/commit/37d1b925d90ddfda3dbcc242c1c739f2aa30d6aa) tls.h: include malloc.h for alloca ### 📊 Changes **4 files changed** (+35 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+11 -7) 📝 `externals/CMakeLists.txt` (+1 -1) 📝 `src/core/libraries/kernel/time.cpp` (+20 -3) 📝 `src/core/tls.h` (+3 -0) </details> ### 📄 Description I fixed the MSYS2 build with clang64. I have also fixed a bug? in `time.cpp`. [`std::chrono::sys_info`](https://en.cppreference.com/w/cpp/chrono/sys_info.html) `offset` was being multiplied by 60 even though it is already in seconds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:04:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3734
No description provided.