[PR #3773] [MERGED] Net: Better return stub for sceNetPoolCreate #3709

New issue

Closed

opened 2026-02-27 22:04:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3773
Author: @StevenMiller123
Created: 11/5/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @georgemoralis

Base: main ← Head: net-pool-create

📝 Commits (1)

d45b86d Better return stub

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/core/libraries/network/net.cpp (+2 -1)

📄 Description

sceNetPoolCreate never returns 0 on success, it returns a positive value as an ID for the net pool. Some games check to make sure the return is positive, these games wouldn't work properly before.

This PR sets the return value of sceNetPoolCreate to a positive, increasing value.
This gets THE PLAYROOM (CUSA00001) further, though now it dies on

[Debug] <Critical> fiber.cpp:42 _sceFiberCheckStackOverflow: Unreachable code!
Stack overflow detected in fiber with size = 0x400

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3773 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 11/5/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `net-pool-create` --- ### 📝 Commits (1) - [`d45b86d`](https://github.com/shadps4-emu/shadPS4/commit/d45b86d3fcecc1665ac040ac07538b2953124486) Better return stub ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/network/net.cpp` (+2 -1) </details> ### 📄 Description sceNetPoolCreate never returns 0 on success, it returns a positive value as an ID for the net pool. Some games check to make sure the return is positive, these games wouldn't work properly before. This PR sets the return value of sceNetPoolCreate to a positive, increasing value. This gets THE PLAYROOM (CUSA00001) further, though now it dies on ``` [Debug] <Critical> fiber.cpp:42 _sceFiberCheckStackOverflow: Unreachable code! Stack overflow detected in fiber with size = 0x400 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>