[PR #3693] [MERGED] Linker: Lock linker mutex in RelocateAnyImports #3659

New issue

Closed

opened 2026-02-27 22:04:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3693
Author: @StevenMiller123
Created: 10/1/2025
Status: ✅ Merged
Merged: 10/1/2025
Merged by: @georgemoralis

Base: main ← Head: linker-fix

📝 Commits (1)

fdfb571 Lock linker mutex in RelocateAnyImports

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/core/linker.h (+2 -0)

📄 Description

Module relocation is not thread safe, games calling LoadAndStartModule on multiple threads can invalidate the m_modules iterators during the loops here.

This fixes crashes during sceKernelLoadStartModule in some apps.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3693 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 10/1/2025 **Status:** ✅ Merged **Merged:** 10/1/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `linker-fix` --- ### 📝 Commits (1) - [`fdfb571`](https://github.com/shadps4-emu/shadPS4/commit/fdfb571f511c0399236867f1f738d088ccb4ad99) Lock linker mutex in RelocateAnyImports ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/core/linker.h` (+2 -0) </details> ### 📄 Description Module relocation is not thread safe, games calling LoadAndStartModule on multiple threads can invalidate the m_modules iterators during the loops here. This fixes crashes during sceKernelLoadStartModule in some apps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>