[PR #3690] [MERGED] videoout: Move HDR swapchain configuration to present thread. #3657

New issue

Closed

opened 2026-02-27 22:04:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3690
Author: @squidbus
Created: 10/1/2025
Status: ✅ Merged
Merged: 10/1/2025
Merged by: @squidbus

Base: main ← Head: hdr

📝 Commits (1)

42549d5 videoout: Move HDR swapchain configuration to present thread.

📊 Changes

3 files changed (+14 additions, -10 deletions)

View changed files

📝 src/core/libraries/videoout/driver.cpp (+3 -0)
📝 src/core/libraries/videoout/driver.h (+1 -1)
📝 src/core/libraries/videoout/video_out.cpp (+10 -9)

📄 Description

On current main I'm hitting a crash when HDR is set up due to threading issues with recreating the Vulkan swapchain during present. Possibly due to recent changes to presenter logic.

Fixing this by moving the HDR swapchain re-configuration into the present thread. Note that we can safely call SetHDR each time as it is a no-op if the current HDR state is the same as input.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3690 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/1/2025 **Status:** ✅ Merged **Merged:** 10/1/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `hdr` --- ### 📝 Commits (1) - [`42549d5`](https://github.com/shadps4-emu/shadPS4/commit/42549d565bd00b8b31d9981f49ce246c62e50ef2) videoout: Move HDR swapchain configuration to present thread. ### 📊 Changes **3 files changed** (+14 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/videoout/driver.cpp` (+3 -0) 📝 `src/core/libraries/videoout/driver.h` (+1 -1) 📝 `src/core/libraries/videoout/video_out.cpp` (+10 -9) </details> ### 📄 Description On current main I'm hitting a crash when HDR is set up due to threading issues with recreating the Vulkan swapchain during present. Possibly due to recent changes to presenter logic. Fixing this by moving the HDR swapchain re-configuration into the present thread. Note that we can safely call `SetHDR` each time as it is a no-op if the current HDR state is the same as input. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>