[PR #3636] [MERGED] Lower "Trophy key is not specified" message from critical to info #3625

New issue

Closed

opened 2026-02-27 22:04:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3636
Author: @Missake212
Created: 9/20/2025
Status: ✅ Merged
Merged: 9/20/2025
Merged by: @squidbus

Base: main ← Head: trophy-key-log

📝 Commits (1)

c891cfb Update trp.cpp

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/core/file_format/trp.cpp (+1 -1)

📄 Description

I think it's not needed to have this logged as critical, it takes an extra second to check if there's a proper critical message in a log when looking at it, and in my experience there's only a handful of games which have issues without the trophy key (only one I know of is "MONOPOLY FAMILY FUN PACK"). I think the following line is more than enough for the end user to realize they won't get any trophies: "[Loader] emulator.cpp:212 Run: Couldn't extract trophies", worse case scenario it can be changed to something like "Couldn't extract trophies because the trophy key is missing" imo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3636 **Author:** [@Missake212](https://github.com/Missake212) **Created:** 9/20/2025 **Status:** ✅ Merged **Merged:** 9/20/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `trophy-key-log` --- ### 📝 Commits (1) - [`c891cfb`](https://github.com/shadps4-emu/shadPS4/commit/c891cfb46de3fc4331cbf588a1e46f6ec6437736) Update trp.cpp ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/file_format/trp.cpp` (+1 -1) </details> ### 📄 Description I think it's not needed to have this logged as critical, it takes an extra second to check if there's a proper critical message in a log when looking at it, and in my experience there's only a handful of games which have issues without the trophy key (only one I know of is "MONOPOLY FAMILY FUN PACK"). I think the following line is more than enough for the end user to realize they won't get any trophies: "[Loader] <Error> emulator.cpp:212 Run: Couldn't extract trophies", worse case scenario it can be changed to something like "Couldn't extract trophies because the trophy key is missing" imo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>