[PR #3599] [MERGED] kernel: More thread code clean-up. #3602

New issue

Closed

opened 2026-02-27 22:04:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3599
Author: @squidbus
Created: 9/14/2025
Status: ✅ Merged
Merged: 9/14/2025
Merged by: @squidbus

Base: main ← Head: thr-clean-2

📝 Commits (1)

9f90eef kernel: More thread code clean-up.

📊 Changes

15 files changed (+84 additions, -89 deletions)

View changed files

📝 src/core/libraries/kernel/threads/condvar.cpp (+17 -17)
📝 src/core/libraries/kernel/threads/event_flag.cpp (+2 -4)
📝 src/core/libraries/kernel/threads/exception.cpp (+1 -1)
📝 src/core/libraries/kernel/threads/mutex.cpp (+3 -3)
📝 src/core/libraries/kernel/threads/pthread.cpp (+31 -30)
📝 src/core/libraries/kernel/threads/pthread.h (+5 -6)
📝 src/core/libraries/kernel/threads/pthread_attr.cpp (+5 -7)
📝 src/core/libraries/kernel/threads/pthread_clean.cpp (+1 -1)
📝 src/core/libraries/kernel/threads/pthread_spec.cpp (+5 -6)
📝 src/core/libraries/kernel/threads/rwlock.cpp (+2 -2)
📝 src/core/libraries/kernel/threads/semaphore.cpp (+1 -1)
📝 src/core/libraries/kernel/threads/sleepq.cpp (+3 -3)
📝 src/core/libraries/kernel/threads/sleepq.h (+1 -1)
📝 src/core/libraries/kernel/threads/stack.cpp (+5 -5)
📝 src/core/libraries/kernel/threads/thread_state.cpp (+2 -2)

📄 Description

Mostly just style warnings like nullptr instead of NULL, use of C++-style casts, using const where possible, type consistency, etc. Added in some std::nothrow constructions as well to make the null checks actually useful.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3599 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/14/2025 **Status:** ✅ Merged **Merged:** 9/14/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `thr-clean-2` --- ### 📝 Commits (1) - [`9f90eef`](https://github.com/shadps4-emu/shadPS4/commit/9f90eef2ba0ec85dcb5dc8a8dc592957c96effc1) kernel: More thread code clean-up. ### 📊 Changes **15 files changed** (+84 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/kernel/threads/condvar.cpp` (+17 -17) 📝 `src/core/libraries/kernel/threads/event_flag.cpp` (+2 -4) 📝 `src/core/libraries/kernel/threads/exception.cpp` (+1 -1) 📝 `src/core/libraries/kernel/threads/mutex.cpp` (+3 -3) 📝 `src/core/libraries/kernel/threads/pthread.cpp` (+31 -30) 📝 `src/core/libraries/kernel/threads/pthread.h` (+5 -6) 📝 `src/core/libraries/kernel/threads/pthread_attr.cpp` (+5 -7) 📝 `src/core/libraries/kernel/threads/pthread_clean.cpp` (+1 -1) 📝 `src/core/libraries/kernel/threads/pthread_spec.cpp` (+5 -6) 📝 `src/core/libraries/kernel/threads/rwlock.cpp` (+2 -2) 📝 `src/core/libraries/kernel/threads/semaphore.cpp` (+1 -1) 📝 `src/core/libraries/kernel/threads/sleepq.cpp` (+3 -3) 📝 `src/core/libraries/kernel/threads/sleepq.h` (+1 -1) 📝 `src/core/libraries/kernel/threads/stack.cpp` (+5 -5) 📝 `src/core/libraries/kernel/threads/thread_state.cpp` (+2 -2) </details> ### 📄 Description Mostly just style warnings like `nullptr` instead of `NULL`, use of C++-style casts, using const where possible, type consistency, etc. Added in some `std::nothrow` constructions as well to make the null checks actually useful. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>