[PR #3596] [CLOSED] liverpool: Finish GPU work before signaling idle. #3598

Closed
opened 2026-02-27 22:04:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3596
Author: @squidbus
Created: 9/13/2025
Status: Closed

Base: mainHead: gpu-idle


📝 Commits (1)

  • 701732f liverpool: Finish GPU work before signaling idle.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/video_core/amdgpu/liverpool.cpp (+1 -1)

📄 Description

Finish pending GPU work before signaling the GpuIdle interrupt, to make sure the guest sees the results in case of e.g. readbacks.

This also fixes Ratchet & Clank (2016) same as https://github.com/shadps4-emu/shadPS4/pull/3593, but with a simpler solution that allows continuing to use scheduler deferred operations.

Performance testing compared to main is appreciated to see if this significantly impacts performance or not.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3596 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/13/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `gpu-idle` --- ### 📝 Commits (1) - [`701732f`](https://github.com/shadps4-emu/shadPS4/commit/701732f19c57df3a8f01120a06bb617d534ce836) liverpool: Finish GPU work before signaling idle. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/liverpool.cpp` (+1 -1) </details> ### 📄 Description Finish pending GPU work before signaling the `GpuIdle` interrupt, to make sure the guest sees the results in case of e.g. readbacks. This also fixes Ratchet & Clank (2016) same as https://github.com/shadps4-emu/shadPS4/pull/3593, but with a simpler solution that allows continuing to use scheduler deferred operations. Performance testing compared to main is appreciated to see if this significantly impacts performance or not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:04:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3598
No description provided.