[PR #3577] [MERGED] vk_rasterizer: Only assert on primitive restart if performing indexed draw. #3586

Closed
opened 2026-02-27 22:04:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3577
Author: @squidbus
Created: 9/12/2025
Status: Merged
Merged: 9/12/2025
Merged by: @squidbus

Base: mainHead: prim-res-check


📝 Commits (1)

  • 0b65e92 vk_rasterizer: Only assert on primitive restart if performing indexed draw.

📊 Changes

2 files changed (+8 additions, -8 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+6 -6)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+2 -2)

📄 Description

Primitive restart only matters if we are actually performing an indexed draw, so don't assert on unsupported restart index if the draw is not indexed.

Fixes instance of this assert in UFC.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3577 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/12/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `prim-res-check` --- ### 📝 Commits (1) - [`0b65e92`](https://github.com/shadps4-emu/shadPS4/commit/0b65e92d1d8cbcbae55fcd5141fe3ea2e94aa6c0) vk_rasterizer: Only assert on primitive restart if performing indexed draw. ### 📊 Changes **2 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+6 -6) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+2 -2) </details> ### 📄 Description Primitive restart only matters if we are actually performing an indexed draw, so don't assert on unsupported restart index if the draw is not indexed. Fixes instance of this assert in UFC. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:04:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3586
No description provided.