[PR #3574] [MERGED] Qt: Group game-specific and non-game-specific items in the same tabs #3583

New issue

Closed

opened 2026-02-27 22:04:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3574
Author: @rainmakerv3
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/14/2025
Merged by: @georgemoralis

Base: main ← Head: tabs

📝 Commits (6)

ec1a6ce Group game-specific and non-game-specific items in the same tabs
d810416 Fix rebase
d46d0dd Transfer default settings tab to general, rename some items
f55b4e8 Fix experimental tab contents not filling the tab
7abae31 prevent saving game specific value if no valid value provided
9244377 Fix console language saving, add error message if trying to save nullopt

📊 Changes

3 files changed (+544 additions, -509 deletions)

View changed files

📝 src/common/config.cpp (+8 -2)
📝 src/qt_gui/settings_dialog.cpp (+30 -35)
📝 src/qt_gui/settings_dialog.ui (+506 -472)

📄 Description

Right now in the game-specific GUI, each individual item has to be manually hidden if it shares a tab with the non-game-specific item, and vice versa.

This simplifies adding items to the GUI (just add them to the appropriate tabs if game specific or non game-specific), and everything that needs to be hidden will already be hidden.

Hiding individual items within tabs also causes certain elements to stretch, so it's also kinda ugly that way.

This however means I kinda had to force certain entries in certain tabs. A couple of things that some might not like:

Trophy key put in the Frontend Tab (formerly the GUI tab)
Default settings tab put in the User Tab

Also, I moved the readbacks and readbacklinearimages to the experimental tab that is only accessible via custom configs. I think it makes sense since you want to enable those on a per-game basis anyway and it's not something probably that we want the casual users touching a lot since we acknowledge that it's experimental

Let me know if this seems iffy

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3574 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/14/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `tabs` --- ### 📝 Commits (6) - [`ec1a6ce`](https://github.com/shadps4-emu/shadPS4/commit/ec1a6ce641e41f8d6e2b1116d165162e54860449) Group game-specific and non-game-specific items in the same tabs - [`d810416`](https://github.com/shadps4-emu/shadPS4/commit/d8104166d35436c7367138a2113b4531d3853f89) Fix rebase - [`d46d0dd`](https://github.com/shadps4-emu/shadPS4/commit/d46d0ddce38e4a665c4ef5ca4534c2e97496e0f1) Transfer default settings tab to general, rename some items - [`f55b4e8`](https://github.com/shadps4-emu/shadPS4/commit/f55b4e8d9a70ac6dccf6ddfe4fd9be06e05d1f9b) Fix experimental tab contents not filling the tab - [`7abae31`](https://github.com/shadps4-emu/shadPS4/commit/7abae3147729b8e782e4a4f1982aae17a2cd1c99) prevent saving game specific value if no valid value provided - [`9244377`](https://github.com/shadps4-emu/shadPS4/commit/92443775f946c73d15ace38000c346391e060ece) Fix console language saving, add error message if trying to save nullopt ### 📊 Changes **3 files changed** (+544 additions, -509 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+8 -2) 📝 `src/qt_gui/settings_dialog.cpp` (+30 -35) 📝 `src/qt_gui/settings_dialog.ui` (+506 -472) </details> ### 📄 Description Right now in the game-specific GUI, each individual item has to be manually hidden if it shares a tab with the non-game-specific item, and vice versa. This simplifies adding items to the GUI (just add them to the appropriate tabs if game specific or non game-specific), and everything that needs to be hidden will already be hidden. Hiding individual items within tabs also causes certain elements to stretch, so it's also kinda ugly that way. This however means I kinda had to force certain entries in certain tabs. A couple of things that some might not like: 1) Trophy key put in the Frontend Tab (formerly the GUI tab) 2) Default settings tab put in the User Tab Also, I moved the readbacks and readbacklinearimages to the experimental tab that is only accessible via custom configs. I think it makes sense since you want to enable those on a per-game basis anyway and it's not something probably that we want the casual users touching a lot since we acknowledge that it's experimental Let me know if this seems iffy --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>