[PR #3535] [MERGED] Libraries: Np libraries cleanup #3551

New issue

Closed

opened 2026-02-27 22:04:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3535
Author: @StevenMiller123
Created: 9/6/2025
Status: ✅ Merged
Merged: 9/6/2025
Merged by: @squidbus

Base: main ← Head: np-stuff

📝 Commits (10+)

9029244 Np library cleanup
97d6ea6 Cleanup NpManager signed_out checks
59cc50d Copyright dates
1d63764 Move signin check to NpManager RegisterLib
854770e Fix RegisterLib names
c8a902e Fix NpCommon exports
e13da0e Basic parameter validation in sceNpDeleteRequest and sceNpCreateRequest
ef9c09f More thorough request logic
57efa73 Functions
b69e522 sceNpGetAccountLanguage, sceNpGetAccountLanguageA

📊 Changes

36 files changed (+828 additions, -13381 deletions)

View changed files

📝 CMakeLists.txt (+19 -20)
📝 src/core/libraries/libc_internal/libc_internal.cpp (+1 -1)
📝 src/core/libraries/libc_internal/libc_internal.h (+1 -1)
📝 src/core/libraries/libs.cpp (+16 -16)
📝 src/core/libraries/ngs2/ngs2.cpp (+1 -1)
📝 src/core/libraries/ngs2/ngs2.h (+1 -1)
📝 src/core/libraries/np/np_auth.cpp (+4 -4)
📝 src/core/libraries/np/np_auth.h (+3 -3)
➕ src/core/libraries/np/np_common.cpp (+105 -0)
➕ src/core/libraries/np/np_common.h (+21 -0)
📝 src/core/libraries/np/np_common_error.h (+1 -2)
➕ src/core/libraries/np/np_error.h (+12 -0)
➕ src/core/libraries/np/np_manager.cpp (+492 -0)
➕ src/core/libraries/np/np_manager.h (+70 -0)
📝 src/core/libraries/np/np_party.cpp (+6 -5)
📝 src/core/libraries/np/np_party.h (+3 -5)
📝 src/core/libraries/np/np_party_error.h (+1 -1)
📝 src/core/libraries/np/np_profile_dialog.cpp (+3 -3)
📝 src/core/libraries/np/np_profile_dialog.h (+2 -2)
📝 src/core/libraries/np/np_score.cpp (+4 -4)

...and 16 more files

📄 Description

This PR:

Moves all libSceNp* implementations into src/core/libraries/np.
Adds np_error.h and np_types.h for storing errors and types frequently seen in multiple Np libraries.
Removes the thousands of auto-stubs generated in libSceNpManager and libSceNpCommon, since most are used internally by VSH/other Np libs and will never need a proper implementation.
Implements basic logic for handling NpRequests.
Implements several basic libSceNpManager functions.
Cleans up the implementation for the isPSNSignedIn setting.

This PR could use some testing, though I don't expect much to change in games.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3535 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 9/6/2025 **Status:** ✅ Merged **Merged:** 9/6/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `np-stuff` --- ### 📝 Commits (10+) - [`9029244`](https://github.com/shadps4-emu/shadPS4/commit/90292447b7415e38f05ed364c13abbe2d8b6139d) Np library cleanup - [`97d6ea6`](https://github.com/shadps4-emu/shadPS4/commit/97d6ea612271f5022f7733dd146e234b55a06914) Cleanup NpManager signed_out checks - [`59cc50d`](https://github.com/shadps4-emu/shadPS4/commit/59cc50d7d4e62c9bc53a000205a8de56b6b3b034) Copyright dates - [`1d63764`](https://github.com/shadps4-emu/shadPS4/commit/1d63764c1a3e931991dae7d658500f397a419fe2) Move signin check to NpManager RegisterLib - [`854770e`](https://github.com/shadps4-emu/shadPS4/commit/854770e244fd7fd6cc5f60daf734a518df399a54) Fix RegisterLib names - [`c8a902e`](https://github.com/shadps4-emu/shadPS4/commit/c8a902e53bce0dd20add61f02615836232f3a1fc) Fix NpCommon exports - [`e13da0e`](https://github.com/shadps4-emu/shadPS4/commit/e13da0e0293d275b9dcfcbfb75d9257331cca33a) Basic parameter validation in sceNpDeleteRequest and sceNpCreateRequest - [`ef9c09f`](https://github.com/shadps4-emu/shadPS4/commit/ef9c09f14579c9f609e8ff63ead0062a48c391f7) More thorough request logic - [`57efa73`](https://github.com/shadps4-emu/shadPS4/commit/57efa73e28059d841b7eafeb13ddb97dd18ab52d) Functions - [`b69e522`](https://github.com/shadps4-emu/shadPS4/commit/b69e5221d8356ce9486ccbd425afdbdb4e662e5f) sceNpGetAccountLanguage, sceNpGetAccountLanguageA ### 📊 Changes **36 files changed** (+828 additions, -13381 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+19 -20) 📝 `src/core/libraries/libc_internal/libc_internal.cpp` (+1 -1) 📝 `src/core/libraries/libc_internal/libc_internal.h` (+1 -1) 📝 `src/core/libraries/libs.cpp` (+16 -16) 📝 `src/core/libraries/ngs2/ngs2.cpp` (+1 -1) 📝 `src/core/libraries/ngs2/ngs2.h` (+1 -1) 📝 `src/core/libraries/np/np_auth.cpp` (+4 -4) 📝 `src/core/libraries/np/np_auth.h` (+3 -3) ➕ `src/core/libraries/np/np_common.cpp` (+105 -0) ➕ `src/core/libraries/np/np_common.h` (+21 -0) 📝 `src/core/libraries/np/np_common_error.h` (+1 -2) ➕ `src/core/libraries/np/np_error.h` (+12 -0) ➕ `src/core/libraries/np/np_manager.cpp` (+492 -0) ➕ `src/core/libraries/np/np_manager.h` (+70 -0) 📝 `src/core/libraries/np/np_party.cpp` (+6 -5) 📝 `src/core/libraries/np/np_party.h` (+3 -5) 📝 `src/core/libraries/np/np_party_error.h` (+1 -1) 📝 `src/core/libraries/np/np_profile_dialog.cpp` (+3 -3) 📝 `src/core/libraries/np/np_profile_dialog.h` (+2 -2) 📝 `src/core/libraries/np/np_score.cpp` (+4 -4) _...and 16 more files_ </details> ### 📄 Description This PR: - Moves all libSceNp* implementations into `src/core/libraries/np`. - Adds `np_error.h` and `np_types.h` for storing errors and types frequently seen in multiple Np libraries. - Removes the thousands of auto-stubs generated in libSceNpManager and libSceNpCommon, since most are used internally by VSH/other Np libs and will never need a proper implementation. - Implements basic logic for handling NpRequests. - Implements several basic libSceNpManager functions. - Cleans up the implementation for the isPSNSignedIn setting. This PR could use some testing, though I don't expect much to change in games. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>