[PR #3533] [MERGED] Qt: Add GUI for game-specific settings #3548

New issue

Closed

opened 2026-02-27 22:04:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3533
Author: @rainmakerv3
Created: 9/5/2025
Status: ✅ Merged
Merged: 9/10/2025
Merged by: @georgemoralis

Base: main ← Head: gsc-gui

📝 Commits (10+)

5d9df06 Open settings dialog from context menu
dfc8f80 initial version complete
c6d2f31 add context menu item to delete game config if it exists
d169b19 Create game config from base value instead of default value
38329bf Require confirmation before deleting game configs with menu item
3de812b fix rebase
abc4da7 Reset game specific values when creating a new game config
213f8ed Add icon for entries with game config
cf4108c clang format
0a693fe Add submenu for game-specific settings

📊 Changes

13 files changed (+896 additions, -628 deletions)

View changed files

📝 REUSE.toml (+1 -0)
📝 src/common/config.cpp (+323 -254)
📝 src/common/config.h (+55 -50)
📝 src/emulator.cpp (+5 -0)
➕ src/images/game_settings.png (+0 -0)
📝 src/qt_gui/game_grid_frame.cpp (+18 -0)
📝 src/qt_gui/game_grid_frame.h (+1 -0)
📝 src/qt_gui/game_list_frame.cpp (+7 -4)
📝 src/qt_gui/gui_context_menus.h (+39 -3)
📝 src/qt_gui/settings_dialog.cpp (+311 -218)
📝 src/qt_gui/settings_dialog.h (+6 -2)
📝 src/qt_gui/settings_dialog.ui (+129 -97)
📝 src/shadps4.qrc (+1 -0)

📄 Description

Closes https://github.com/shadps4-emu/shadPS4/issues/3512

This incredibly tedious pain of PR adds a GUI for configuration of game-specific settings, accessible for the right-click context menu.

Quick initial tests are ok, but probably needs a lot of testing since this touches config files a lot. (You may want to backup your configs before testing, there's high potential for error here lol)

It's also just kinda ugly since all the non game-specific UI elements were hidden. In the future maybe we can do it like RPCS3 and group all the game-specific and non game-specific stuff in the same tabs.

EDIT: Summary of changes

Added game-specific gui options from context menu, this will open the settings dialog with all the global-only settings hidden and will show the game-specific experimental options. All options are in a sub-menu and has separate entries to create/configure/delete game configs
save and restore values functions changed to save/set default only game-specific values if called from the game-specific GUI
Added icons in the GUI to denote whether a game in the list/grid has a custom config
Added logging for isDevkit, and also if custom game config exists
Added the other experimental settings only to the game-specific settings GUI

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3533 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/10/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `gsc-gui` --- ### 📝 Commits (10+) - [`5d9df06`](https://github.com/shadps4-emu/shadPS4/commit/5d9df064f674a196fa94f361e93672dd167672ac) Open settings dialog from context menu - [`dfc8f80`](https://github.com/shadps4-emu/shadPS4/commit/dfc8f80064cc2ecbc7104c27d921cfa896dd68c7) initial version complete - [`c6d2f31`](https://github.com/shadps4-emu/shadPS4/commit/c6d2f31e84e72de654115431b16a10c6e30e0cb6) add context menu item to delete game config if it exists - [`d169b19`](https://github.com/shadps4-emu/shadPS4/commit/d169b19b6aa036dc03438fe060e059c42f2a1ea5) Create game config from base value instead of default value - [`38329bf`](https://github.com/shadps4-emu/shadPS4/commit/38329bf140267eb1edfcef8b738cc691c0f8bdf8) Require confirmation before deleting game configs with menu item - [`3de812b`](https://github.com/shadps4-emu/shadPS4/commit/3de812b9e4038c45be0006c9e3d7c25962b03c13) fix rebase - [`abc4da7`](https://github.com/shadps4-emu/shadPS4/commit/abc4da70ff8f0c54c8433d3b200692f5d246b3dd) Reset game specific values when creating a new game config - [`213f8ed`](https://github.com/shadps4-emu/shadPS4/commit/213f8ede3969af7389ba97d6aaa35649c3096249) Add icon for entries with game config - [`cf4108c`](https://github.com/shadps4-emu/shadPS4/commit/cf4108ca163b489a2ba9c485c0d0cb76b2e0d522) clang format - [`0a693fe`](https://github.com/shadps4-emu/shadPS4/commit/0a693fe34266adcb3ea15eaddf0c1bd031c1a64d) Add submenu for game-specific settings ### 📊 Changes **13 files changed** (+896 additions, -628 deletions) <details> <summary>View changed files</summary> 📝 `REUSE.toml` (+1 -0) 📝 `src/common/config.cpp` (+323 -254) 📝 `src/common/config.h` (+55 -50) 📝 `src/emulator.cpp` (+5 -0) ➕ `src/images/game_settings.png` (+0 -0) 📝 `src/qt_gui/game_grid_frame.cpp` (+18 -0) 📝 `src/qt_gui/game_grid_frame.h` (+1 -0) 📝 `src/qt_gui/game_list_frame.cpp` (+7 -4) 📝 `src/qt_gui/gui_context_menus.h` (+39 -3) 📝 `src/qt_gui/settings_dialog.cpp` (+311 -218) 📝 `src/qt_gui/settings_dialog.h` (+6 -2) 📝 `src/qt_gui/settings_dialog.ui` (+129 -97) 📝 `src/shadps4.qrc` (+1 -0) </details> ### 📄 Description Closes https://github.com/shadps4-emu/shadPS4/issues/3512 This incredibly tedious pain of PR adds a GUI for configuration of game-specific settings, accessible for the right-click context menu. Quick initial tests are ok, but probably needs a lot of testing since this touches config files a lot. (You may want to backup your configs before testing, there's high potential for error here lol) It's also just kinda ugly since all the non game-specific UI elements were hidden. In the future maybe we can do it like RPCS3 and group all the game-specific and non game-specific stuff in the same tabs. <img width="969" height="775" alt="image" src="https://github.com/user-attachments/assets/92255fa7-fa1a-417b-979b-b80b625cab8a" /> EDIT: Summary of changes 1) Added game-specific gui options from context menu, this will open the settings dialog with all the global-only settings hidden and will show the game-specific experimental options. All options are in a sub-menu and has separate entries to create/configure/delete game configs 2) save and restore values functions changed to save/set default only game-specific values if called from the game-specific GUI 3) Added icons in the GUI to denote whether a game in the list/grid has a custom config 4) Added logging for isDevkit, and also if custom game config exists 5) Added the other experimental settings only to the game-specific settings GUI --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>