[PR #3488] [MERGED] semaphore: Invert priority order. #3510

New issue

Closed

opened 2026-02-27 22:03:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3488
Author: @squidbus
Created: 8/31/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @squidbus

Base: main ← Head: sem-prio

📝 Commits (2)

9a289a6 semaphore: Invert priority order.
bf07b11 playgo: Lower logs for some spammed functions.

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 src/core/libraries/kernel/threads/semaphore.cpp (+2 -2)
📝 src/core/libraries/playgo/playgo.cpp (+4 -4)

📄 Description

Currently, priority-based OrbisSem treats a greater number as a greater priority. However, thread priorities should be ordered smallest-first. Fix the ordering by inverting the condition, such that:

Smaller priority number wins.
In ties, the new waiter is added to the end.

Additionally, lowered a few PlayGo logs to Debug as some games spam these functions infinitely to monitor status in the background.

Fixes hang on load in Valkyria Revolution (CUSA06810).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3488 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 8/31/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `sem-prio` --- ### 📝 Commits (2) - [`9a289a6`](https://github.com/shadps4-emu/shadPS4/commit/9a289a6afac6daa225fc35d87cb5fc6a58cf06a7) semaphore: Invert priority order. - [`bf07b11`](https://github.com/shadps4-emu/shadPS4/commit/bf07b11249e60cd3968b3a54490be80f95ac1433) playgo: Lower logs for some spammed functions. ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/kernel/threads/semaphore.cpp` (+2 -2) 📝 `src/core/libraries/playgo/playgo.cpp` (+4 -4) </details> ### 📄 Description Currently, priority-based `OrbisSem` treats a greater number as a greater priority. However, thread priorities should be ordered smallest-first. Fix the ordering by inverting the condition, such that: * Smaller priority number wins. * In ties, the new waiter is added to the end. Additionally, lowered a few PlayGo logs to Debug as some games spam these functions infinitely to monitor status in the background. Fixes hang on load in Valkyria Revolution (CUSA06810). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>