[PR #3479] [MERGED] vk_scheduler: Properly initialize vulkan structures in RenderState. #3501

Closed
opened 2026-02-27 22:03:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3479
Author: @squidbus
Created: 8/29/2025
Status: Merged
Merged: 8/30/2025
Merged by: @squidbus

Base: mainHead: attach-init


📝 Commits (2)

  • 6d64efc vk_scheduler: Properly initialize vulkan structures in RenderState.
  • 1d5e5fe vk_scheduler: Fix gcc build

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_scheduler.h (+3 -0)

📄 Description

Since RenderState is zero-initialized for equality check purposes, make sure to always initialize the attachment infos after to have the proper Vulkan struct type.

Fixes validation errors related to these not having the right type.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3479 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 8/29/2025 **Status:** ✅ Merged **Merged:** 8/30/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `attach-init` --- ### 📝 Commits (2) - [`6d64efc`](https://github.com/shadps4-emu/shadPS4/commit/6d64efce87d5f2d0b71395afe02f6eab3745165a) vk_scheduler: Properly initialize vulkan structures in RenderState. - [`1d5e5fe`](https://github.com/shadps4-emu/shadPS4/commit/1d5e5fe33141ea24108db3c4ace3489dfd2964ef) vk_scheduler: Fix gcc build ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_scheduler.h` (+3 -0) </details> ### 📄 Description Since `RenderState` is zero-initialized for equality check purposes, make sure to always initialize the attachment infos after to have the proper Vulkan struct `type`. Fixes validation errors related to these not having the right `type`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:03:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#3501
No description provided.