[PR #3459] [CLOSED] Fix resetting patches when the isEnabled field is not present #3485

New issue

Closed

opened 2026-02-27 22:03:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3459
Author: @kalaposfos13
Created: 8/25/2025
Status: ❌ Closed

Base: main ← Head: patch-enable-reset

📝 Commits (1)

bee14d7 Fix resetting patches when the isEnabled field is not present

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/common/memory_patcher.cpp (+1 -0)

📄 Description

Fixes the issue when you have two patches like so:

<Metadata Title="game" Name="patch1" Note="" Author="kalaposfos" PatchVer="1.0" AppVer="01.00" AppElf="eboot.bin" isEnabled="true">
    <PatchList>
        <Line Type="bytes" Address="0x0068bf60" Value="31c0c3"/>
    </PatchList>
</Metadata>
<Metadata Title="game" Name="patch2" Note="" Author="kalaposfos" PatchVer="1.0" AppVer="01.00" AppElf="eboot.bin">
    <PatchList>
        <Line Type="bytes" Address="0x0068bf60" Value="31c0c3"/>
    </PatchList>
</Metadata>

The first has the isEnabled field, but the second does not. The expected behaviour would be that the first is turned on, but the second isn't, but what happens is that both get turned on, because the internal isEnabled flag doesn't get reset, so the first "true" gets carried over.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3459 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 8/25/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-enable-reset` --- ### 📝 Commits (1) - [`bee14d7`](https://github.com/shadps4-emu/shadPS4/commit/bee14d770b68f73895f6b598da047d0a14a4aa33) Fix resetting patches when the isEnabled field is not present ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/common/memory_patcher.cpp` (+1 -0) </details> ### 📄 Description Fixes the issue when you have two patches like so: ```xml <Metadata Title="game" Name="patch1" Note="" Author="kalaposfos" PatchVer="1.0" AppVer="01.00" AppElf="eboot.bin" isEnabled="true"> <PatchList> <Line Type="bytes" Address="0x0068bf60" Value="31c0c3"/> </PatchList> </Metadata> <Metadata Title="game" Name="patch2" Note="" Author="kalaposfos" PatchVer="1.0" AppVer="01.00" AppElf="eboot.bin"> <PatchList> <Line Type="bytes" Address="0x0068bf60" Value="31c0c3"/> </PatchList> </Metadata> ``` The first has the isEnabled field, but the second does not. The expected behaviour would be that the first is turned on, but the second isn't, but what happens is that both get turned on, because the internal isEnabled flag doesn't get reset, so the first "true" gets carried over. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>