[PR #3439] [MERGED] Allow vector and scalar offset in buffer address arg to LoadBuffer/StoreBuffer #3467

New issue

Closed

opened 2026-02-27 22:03:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3439
Author: @baggins183
Created: 8/21/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @squidbus

Base: main ← Head: buffer-addr-changes

📝 Commits (7)

49b50d6 Allow vector and scalar offset in buffer address arg to
3d1bf92 remove is_ring check
97d7f21 fix atomics and update pattern matching for tess factor stores
3eba62c remove old asserts about soffset
1d4f28a small fixes
bc9178d copyright
6281352 Handle sgpr initialization for 2 special hull shader values, including tess factor buffer offset

📊 Changes

14 files changed (+135 additions, -87 deletions)

View changed files

📝 CMakeLists.txt (+1 -0)
📝 src/shader_recompiler/frontend/translate/translate.cpp (+8 -0)
📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+17 -61)
📝 src/shader_recompiler/ir/attribute.cpp (+4 -0)
📝 src/shader_recompiler/ir/attribute.h (+2 -0)
➕ src/shader_recompiler/ir/operand_helper.h (+48 -0)
📝 src/shader_recompiler/ir/passes/hull_shader_transform.cpp (+19 -7)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+18 -14)
📝 src/shader_recompiler/ir/passes/ring_access_elimination.cpp (+7 -4)
📝 src/shader_recompiler/ir/pattern_matching.h (+2 -0)
📝 src/shader_recompiler/ir/reg.h (+1 -1)
📝 src/shader_recompiler/runtime_info.h (+1 -0)
📝 src/video_core/amdgpu/liverpool.h (+6 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+1 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3439 **Author:** [@baggins183](https://github.com/baggins183) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `buffer-addr-changes` --- ### 📝 Commits (7) - [`49b50d6`](https://github.com/shadps4-emu/shadPS4/commit/49b50d6a9f1d5eeb71c87554e9050c29b839ffa4) Allow vector and scalar offset in buffer address arg to - [`3d1bf92`](https://github.com/shadps4-emu/shadPS4/commit/3d1bf92acce3030939d4d507baf1e39bfe5b0bed) remove is_ring check - [`97d7f21`](https://github.com/shadps4-emu/shadPS4/commit/97d7f219ecb1d540ad52016c972f5b5d0278b0fd) fix atomics and update pattern matching for tess factor stores - [`3eba62c`](https://github.com/shadps4-emu/shadPS4/commit/3eba62c18e95ec3b2093cf489d9466996e7e3e52) remove old asserts about soffset - [`1d4f28a`](https://github.com/shadps4-emu/shadPS4/commit/1d4f28add3e1413d4502c125aab178a7f335cd2f) small fixes - [`bc9178d`](https://github.com/shadps4-emu/shadPS4/commit/bc9178de76ffbb85a2779a95497a300891d1d5e9) copyright - [`6281352`](https://github.com/shadps4-emu/shadPS4/commit/62813526cb3e515c4b04a533a75f28ec85839953) Handle sgpr initialization for 2 special hull shader values, including tess factor buffer offset ### 📊 Changes **14 files changed** (+135 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+1 -0) 📝 `src/shader_recompiler/frontend/translate/translate.cpp` (+8 -0) 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+17 -61) 📝 `src/shader_recompiler/ir/attribute.cpp` (+4 -0) 📝 `src/shader_recompiler/ir/attribute.h` (+2 -0) ➕ `src/shader_recompiler/ir/operand_helper.h` (+48 -0) 📝 `src/shader_recompiler/ir/passes/hull_shader_transform.cpp` (+19 -7) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+18 -14) 📝 `src/shader_recompiler/ir/passes/ring_access_elimination.cpp` (+7 -4) 📝 `src/shader_recompiler/ir/pattern_matching.h` (+2 -0) 📝 `src/shader_recompiler/ir/reg.h` (+1 -1) 📝 `src/shader_recompiler/runtime_info.h` (+1 -0) 📝 `src/video_core/amdgpu/liverpool.h` (+6 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+1 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>