[PR #3426] [MERGED] Improve heuristic for attributes passed via ring buffers. #3456

New issue

Closed

opened 2026-02-27 22:03:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3426
Author: @baggins183
Created: 8/17/2025
Status: ✅ Merged
Merged: 8/17/2025
Merged by: @georgemoralis

Base: main ← Head: ring-fix

📝 Commits (1)

ce57ec9 Improve heuristic for attributes passed via ring buffers.

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+6 -2)

📄 Description

Previously a buffer load in a vertex shader could be treated like a ring access, dropping offen vgpr and possibly asserting during resource tracking because of mismatch between types (u32x2 vs U32), caused by inconsistencies in flags (index_enable and offset_enable)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3426 **Author:** [@baggins183](https://github.com/baggins183) **Created:** 8/17/2025 **Status:** ✅ Merged **Merged:** 8/17/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `ring-fix` --- ### 📝 Commits (1) - [`ce57ec9`](https://github.com/shadps4-emu/shadPS4/commit/ce57ec951992132ef9b35ac36873fdbc23ccbda3) Improve heuristic for attributes passed via ring buffers. ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+6 -2) </details> ### 📄 Description Previously a buffer load in a vertex shader could be treated like a ring access, dropping offen vgpr and possibly asserting during resource tracking because of mismatch between types (u32x2 vs U32), caused by inconsistencies in flags (index_enable and offset_enable) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>