[PR #3386] [MERGED] FF9 ImeDialog Hotfix #3434

New issue

Closed

opened 2026-02-27 22:03:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3386
Author: @w1naenator
Created: 8/4/2025
Status: ✅ Merged
Merged: 8/5/2025
Merged by: @georgemoralis

Base: main ← Head: ime-fixes

📝 Commits (10+)

68ac301 Changes
ed14ca8 Potential CUSA00434 [Debug] assert.cpp:30 assert_fail_debug_msg: Assertion Failed!
557fb7f Attempting to resolve an assertion failure in Diablo III:
aa65d7b Merge branch 'main' into ime-fixes
f67b3d8 ime-lib another hotfix
136066c Merge branch 'ime-fixes' of https://github.com/w1naenator/shadPS4 into ime-fixes
7ebb2bd Merge branch 'main' into ime-fixes
38dc288 Clang fix
1ae476d Merge branch 'shadps4-emu:main' into ime-fixes
9696043 FF9 ImeDialog Hotfix

📊 Changes

1 file changed (+60 additions, -24 deletions)

View changed files

📝 src/core/libraries/ime/ime_dialog.cpp (+60 -24)

📄 Description

Removed the validation that disallowed null text and null placeholder, since using null values is valid in ImeDialog.
Added additional debug logs to aid troubleshooting.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3386 **Author:** [@w1naenator](https://github.com/w1naenator) **Created:** 8/4/2025 **Status:** ✅ Merged **Merged:** 8/5/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `ime-fixes` --- ### 📝 Commits (10+) - [`68ac301`](https://github.com/shadps4-emu/shadPS4/commit/68ac30106128ed8594dc815bed92ea5bc1191600) Changes - [`ed14ca8`](https://github.com/shadps4-emu/shadPS4/commit/ed14ca8026ee2848e841d1ce52ad7bfe3d744dd1) Potential CUSA00434 [Debug] <Critical> assert.cpp:30 assert_fail_debug_msg: Assertion Failed! - [`557fb7f`](https://github.com/shadps4-emu/shadPS4/commit/557fb7f6f5bdad168a49e2b788c42a19f3250996) Attempting to resolve an assertion failure in Diablo III: - [`aa65d7b`](https://github.com/shadps4-emu/shadPS4/commit/aa65d7bc2b772b0fd077693503c18e38fe95ee1a) Merge branch 'main' into ime-fixes - [`f67b3d8`](https://github.com/shadps4-emu/shadPS4/commit/f67b3d8f97ad27693e0fdf5456f41f3da4a3e7df) ime-lib another hotfix - [`136066c`](https://github.com/shadps4-emu/shadPS4/commit/136066cf0ba7960cd14fe63adaa2be1b0182fd45) Merge branch 'ime-fixes' of https://github.com/w1naenator/shadPS4 into ime-fixes - [`7ebb2bd`](https://github.com/shadps4-emu/shadPS4/commit/7ebb2bdc48e91ca7cf690049f46d3c24138b753f) Merge branch 'main' into ime-fixes - [`38dc288`](https://github.com/shadps4-emu/shadPS4/commit/38dc288ac3f78a672c973c78fd5cd3c03a84b4e8) Clang fix - [`1ae476d`](https://github.com/shadps4-emu/shadPS4/commit/1ae476d2c1cd2bfa0fe5fb66f4ef31534adcbc55) Merge branch 'shadps4-emu:main' into ime-fixes - [`9696043`](https://github.com/shadps4-emu/shadPS4/commit/9696043a565efcbc49c35da7b12a4414aa3e467c) FF9 ImeDialog Hotfix ### 📊 Changes **1 file changed** (+60 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/ime/ime_dialog.cpp` (+60 -24) </details> ### 📄 Description - Removed the validation that disallowed null text and null placeholder, since using null values is valid in `ImeDialog`. - Added additional debug logs to aid troubleshooting. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>