[PR #3326] [MERGED] texture_cache: Do not modify mip height for copy in volume texture. #3392

New issue

Closed

opened 2026-02-27 22:03:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3326
Author: @squidbus
Created: 7/25/2025
Status: ✅ Merged
Merged: 7/25/2025
Merged by: @squidbus

Base: main ← Head: voltex

📝 Commits (1)

9c70d4c texture_cache: Do not modify mip height for copy in volume texture.

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 src/video_core/texture_cache/texture_cache.cpp (+4 -2)

📄 Description

As noted with TLG in https://github.com/shadps4-emu/shadPS4/pull/3261, the change to mip_height when refreshing textures may not be aligned correctly for volume textures. It seems this was fixed for TLG by using max(mip_height, 8) instead of aligning, but this is still an issue for at least Sakura Wars.

For now at least, excluding volume textures from this alignment.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3326 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 7/25/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `voltex` --- ### 📝 Commits (1) - [`9c70d4c`](https://github.com/shadps4-emu/shadPS4/commit/9c70d4c5c681a5fed537b3376c74281bbc940698) texture_cache: Do not modify mip height for copy in volume texture. ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/texture_cache.cpp` (+4 -2) </details> ### 📄 Description As noted with TLG in https://github.com/shadps4-emu/shadPS4/pull/3261, the change to `mip_height` when refreshing textures may not be aligned correctly for volume textures. It seems this was fixed for TLG by using `max(mip_height, 8)` instead of aligning, but this is still an issue for at least Sakura Wars. For now at least, excluding volume textures from this alignment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>