[PR #3299] [MERGED] Core: Only update configs when using a different build. #3367

New issue

Closed

opened 2026-02-27 22:03:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3299
Author: @StevenMiller123
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @georgemoralis

Base: main ← Head: update-config-logic

📝 Commits (2)

0d0fcd5 Use a config version constant to check for config updates
f80e7b8 Use git revision hash instead of constant

📊 Changes

1 file changed (+6 additions, -21 deletions)

View changed files

📝 src/common/config.cpp (+6 -21)

📄 Description

This PR adds the currently used emulator revision to the config file, and if there's a mismatch between the current revision and the stored revision, a config update will be triggered.

Using this logic addresses the issue where configs with additional entries would trigger a config update on each emulator boot, and removes the requirement for PR authors to increment a constant every time they add a new config entry.

Outside of rewriting config logic to check for the existance of each individual option, I don't see a better solution at this time. I'm also still opting not to clear old/unused config entries, since doing so could interfere with some people's PR/fork testing, though it comes with the downside of cluttering the config file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3299 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `update-config-logic` --- ### 📝 Commits (2) - [`0d0fcd5`](https://github.com/shadps4-emu/shadPS4/commit/0d0fcd5d846900e10098ce236a7854b6dbf73028) Use a config version constant to check for config updates - [`f80e7b8`](https://github.com/shadps4-emu/shadPS4/commit/f80e7b81b57013ba6e87c63e250eeff288bb0dea) Use git revision hash instead of constant ### 📊 Changes **1 file changed** (+6 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+6 -21) </details> ### 📄 Description This PR adds the currently used emulator revision to the config file, and if there's a mismatch between the current revision and the stored revision, a config update will be triggered. Using this logic addresses the issue where configs with additional entries would trigger a config update on each emulator boot, and removes the requirement for PR authors to increment a constant every time they add a new config entry. Outside of rewriting config logic to check for the existance of each individual option, I don't see a better solution at this time. I'm also still opting not to clear old/unused config entries, since doing so could interfere with some people's PR/fork testing, though it comes with the downside of cluttering the config file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>